You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With #2140 and #2112, the main icu_properties return values are all consistently named. We have CodePoint[Set|Map]Data(Borrowed)? as a naming scheme for the main APIs for interacting with this data. Stringy maps and sets can be supported in the future with [Unicode|CodePoint]{Set|Map]Data(Borrowed)?
So far, the data structs have not been renamed. They're currently called UnicodePropertyV1 and UnicodePropertyMapV1, which isn't great. Note that these types are not super important since users shouldn't be interfacing with them, but consistent naming woudl be nice.
@echeran suggested Property[Unicode|CodePoint][Set|Map]V1. I like having Property in the name there.
Also we have UnicodeSet. I don't think we need as much consistency there: that's a specific backend and doesn't need to be named analogously to other backends, but we probably should name it CodePointSet or something (and rename the builder type and associated methods).
The text was updated successfully, but these errors were encountered:
Carried over from #1239
With #2140 and #2112, the main icu_properties return values are all consistently named. We have
CodePoint[Set|Map]Data(Borrowed)?
as a naming scheme for the main APIs for interacting with this data. Stringy maps and sets can be supported in the future with[Unicode|CodePoint]{Set|Map]Data(Borrowed)?
So far, the data structs have not been renamed. They're currently called
UnicodePropertyV1
andUnicodePropertyMapV1
, which isn't great. Note that these types are not super important since users shouldn't be interfacing with them, but consistent naming woudl be nice.@echeran suggested
Property[Unicode|CodePoint][Set|Map]V1
. I like having Property in the name there.Also we have
UnicodeSet
. I don't think we need as much consistency there: that's a specific backend and doesn't need to be named analogously to other backends, but we probably should name itCodePointSet
or something (and rename the builder type and associated methods).The text was updated successfully, but these errors were encountered: