Skip to content

CLDR-18494 Add Nselxcin locale #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

CLDR-18494 Add Nselxcin locale #4596

wants to merge 10 commits into from

Conversation

conradarcturus
Copy link
Contributor

CLDR-18494

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@conradarcturus conradarcturus added the ddl DDL-SC specific work label Apr 9, 2025
@conradarcturus conradarcturus self-assigned this Apr 9, 2025
@conradarcturus conradarcturus force-pushed the CLDR-18494-add-oka-locale branch from 9a56f88 to dbcc8ff Compare April 9, 2025 18:33
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/main/oka.xml is different
  • common/supplemental/likelySubtags.xml is now changed in the branch
  • common/supplemental/supplementalData.xml is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

srl295
srl295 previously approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but lots of stray generated lines

@conradarcturus
Copy link
Contributor Author

Hmmm, it looks like Unicode character 'COMBINING COMMA ABOVE' (U+0313) is not accepted by the exemplar data right now. Running the exemplar rebuild didn't go anything:

mvn -DSHOW_EXEMPLARS test --file tools/pom.xml '-Dorg.unicode.cldr.unittest.testArgs=-f:LikelySubtagsTest -n -q'

@conradarcturus conradarcturus marked this pull request as ready for review April 17, 2025 01:00
@conradarcturus conradarcturus requested a review from srl295 April 17, 2025 01:00
@conradarcturus
CLDR-18494 merge from main
beb0527
@conradarcturus
CLDR-18494 Rebuild exemplars
52204bb 
Rebuild exemplars since they were updated when adding `sgs`
@conradarcturus conradarcturus changed the title CLDR-18494 Add Okanagan locale CLDR-18494 Add Nselxcin locale Apr 18, 2025
srl295
srl295 approved these changes Apr 18, 2025
View reviewed changes
common/main/en.xml
@@ -481,6 +481,7 @@ annotations.
<language type="ojs">Oji-Cree</language>
<language type="ojw">Western Ojibwa</language>
<language type="oka">Okanagan</language>
<language type="oka" alt="variant">Nselxcin</language>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macchiati @AEApple did we get TC consensus that the variant was OK to add at this point? ( CLDR-18522 on this topic)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not change the name of the language, just adding a variant.

If you would like, I can leave it out of this PR anyway. I like adding variant names early but I think your protocol waits longer for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if we had consensus on it - higher bar than adding oka and does show up in all locales even if at a higher coverage level

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alt value should show up with exactly the same coverage as the no-alt value, except where there is an explicit exception. Since it is in en (not root) it wouldn't show up in other languages.

srl295
srl295 reviewed Apr 18, 2025
View reviewed changes
common/supplemental/supplementalMetadata.xml
@@ -1909,7 +1909,7 @@ For terms of use, see http://www.unicode.org/copyright.html
mt_MT mua_CM mus_US my_MM myv_RU mzn_IR
naq_NA nb nb_NO nd_ZW nds_DE ne_NP nl_NL nmg_CM nn_NO nnh_CM nqo_GN nr_ZA
nso_ZA nus_SS nv_US ny_MW nyn_UG
oc_FR om_ET or_IN os_GE osa_US
oc_FR oka_US om_ET or_IN os_GE osa_US
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely for oka is oka_Latn_CA please check

macchiati
macchiati reviewed Apr 28, 2025
View reviewed changes
common/main/oka.xml
</orientation>
</layout>
<characters>
<exemplarCharacters>[a á {aˤ} {áˤ} c c̓ č ə ɣ h i í k k̓ {kʷ} {k̓ʷ} l l̓ ɬ ƛ̓ m m̓ n n̓ p p̓ q q̓ {qʷ} {q̓ʷ} r s t t̓ u ú w w̓ x {xʷ} {x̌} {x̌ʷ} y y̓ ʕ ʕ̓ {ʕʷ} {ʕ̓ʷ} ʔ]</exemplarCharacters>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: Should be limited to (specific-script - uppercase - invisibles + İ); thus not contain: ‎[\u0313]‎

This looks like it is an error in the Check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

@macchiati macchiati macchiati left review comments

@DavidLRowe DavidLRowe Awaiting requested review from DavidLRowe

@btangmu btangmu Awaiting requested review from btangmu

@pedberg-icu pedberg-icu Awaiting requested review from pedberg-icu

Assignees

@conradarcturus conradarcturus

Labels
ddl DDL-SC specific work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conradarcturus @srl295 @macchiati