Redesign for constraints page #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdccollins
force-pushed
the
update-constraint-page
branch
from
94173ca to
af01fc7
Compare
app/assets/stylesheets/_main.scss
Outdated
|
|
||
| .dashed-box { | ||
| padding: 30px; | ||
| border: 1px dashed #B1B4B6; |
There was a problem hiding this comment.
It might be better to use the govuk-colour function rather than the hex code:
Suggested change
| border: 1px dashed #B1B4B6; | |
| border: 1px dashed govuk-colour("mid-grey"); |
cdccollins
force-pushed
the
update-constraint-page
branch
from
af01fc7 to
f7888a6
Compare
| <% end %> | ||
| <% else %> | ||
| <tr class="govuk-table__row"> | ||
| <td class="govuk-table__cell" colspan="4" style="border-bottom: none;"> |
There was a problem hiding this comment.
We have a class for that:
Suggested change
| <td class="govuk-table__cell" colspan="4" style="border-bottom: none;"> | |
| <td class="govuk-table__cell border-bottom-none" colspan="4"> |
benjamineskola
approved these changes
Apr 23, 2024
pixeltrix
requested changes
Apr 23, 2024
|
|
||
| def update | ||
| ActiveRecord::Base.transaction do | ||
| @planning_application.update!(updated_address_or_boundary_geojson: true) | ||
| @planning_application.constraints_checked! | ||
| end |
There was a problem hiding this comment.
This should probably be extracted to a method on the model
| def constraints_to_add | ||
| @constraints_to_add ||= constraint_ids - existing_constraint_ids | ||
| def set_other_constraints | ||
| @other_constraints = Constraint.all_constraints(search_param).non_applicable_constraints(@planning_application.planning_application_constraints).sort_by(&:category) |
There was a problem hiding this comment.
This should be a method on the Constraint model, e.g.
@other_constraints = Constraint.other_constraints(search_param, @planning_application)
| resource :constraints, only: %i[show update] | ||
| resources :constraints, only: %i[index create destroy] do | ||
| patch :update, on: :collection | ||
| end |
There was a problem hiding this comment.
Because I wanted the :id on the create and destroy method?
cdccollins
force-pushed
the
update-constraint-page
branch
2 times, most recently
from
b27d514 to
5185340
Compare
pixeltrix
approved these changes
Apr 23, 2024
EGiataganas
approved these changes
Apr 23, 2024
cdccollins
force-pushed
the
update-constraint-page
branch
from
5185340 to
8fbf84f
Compare
- Add/Remove links rather than checkboxes - Can't remove constraints identified by system - Can search for constraints
cdccollins
force-pushed
the
update-constraint-page
branch
from
8fbf84f to
36159f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Story Link
https://trello.com/c/qkrP4O3J/2796-the-source-of-the-constraints
Screenshots