Improve layout for querying neighbour addresses by polygon search #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbaumann95
commented
Sep 4, 2023
app/models/consultation.rb
Outdated
| "#{polygon_colour}20" | ||
| end | ||
|
|
||
| def concatenate_geojsons(*geojsons) |
There was a problem hiding this comment.
Need this to represent one geosjon FeatureCollection with all the geosjon features (planning application red line boundary, consultation boundary etc) so we can present this on one map.
If the column type is polygon_geojson we insert the polygon colour so that the map component can distinguish the type of feature
benbaumann95
force-pushed
the
update-map
branch
from
92ef7ab to
60da2cf
Compare
benbaumann95
commented
Sep 4, 2023
| extend ActiveSupport::Concern | ||
|
|
||
| class_methods do | ||
| def format_geojson_epsg(column_name) |
There was a problem hiding this comment.
the map component introduces a breaking change here - https://github.com/theopensystemslab/map/pull/256/files
This is to ensure compatibility with the previous way we store geojson
benbaumann95
changed the title
benbaumann95
force-pushed
the
update-map
branch
5 times, most recently
from
ddcf3a8 to
d9872da
Compare
benbaumann95
force-pushed
the
update-map
branch
from
d9872da to
8a1afc6
Compare
app/controllers/planning_application/consultations_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/planning_application/consultations_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/planning_application/consultations_controller.rb
Outdated
Show resolved
Hide resolved
benbaumann95
force-pushed
the
update-map
branch
from
8a1afc6 to
88e90aa
Compare
benjamineskola
approved these changes
Sep 8, 2023
benbaumann95
force-pushed
the
update-map
branch
8 times, most recently
from
a550b24 to
90afc77
Compare
benjamineskola
approved these changes
Sep 11, 2023
added 2 commits
September 11, 2023 10:01
- Update previous longitude / latitude string values to use this new geographic format - These legacy columns are to be removed in a subsequent PR
benbaumann95
force-pushed
the
update-map
branch
from
90afc77 to
7144e62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR allows multiple geojson features to be stored on a single map as part of a "FeatureCollection". This enables us to have the consultation polygon overlay the planning application red line boundary. In theory, if we allowed multiple geojson features for the polygon search we could combine this in one map too. We are also able to draw in a specified colour using drawColor and drawFillColor props.
The colour is now set differently for the polygon boundary to distinguish from the red line boundary. This has been done by setting a colour property attribute on the feature which the map component will dynamically set.
Some updates were necessary on the map component to achieve the above.
See: theopensystemslab/map#381 & theopensystemslab/map#379
Story Link
https://trello.com/c/IQsb3WNF/1908-improve-content-and-layout-for-querying-neighbour-addresses-by-polygon-search
Screenshots
Drawn polygon boundary is saved in another colour
Drawing the consultation polygon in another colour