-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable magicComment features by default #1667
Conversation
Walkthrough此次变更涉及对配置文件 Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
crates/mako/src/config/mako.config.default.json (1)
70-70
: 确认实验性功能的稳定性
由于magicComment
位于experimental
配置段中,建议:
- 评估是否应该将其移出实验性功能区
- 确保功能已经足够稳定可靠
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- crates/mako/src/config/mako.config.default.json (1 hunks)
🔇 Additional comments (1)
crates/mako/src/config/mako.config.default.json (1)
70-70
: 建议在启用实验性功能前进行充分验证
虽然PR描述提到该功能已在多个大型内部项目和G6官网中得到验证,但作为默认配置的更改可能会影响到所有用户。建议:
- 确保有完整的功能文档
- 考虑提供迁移指南
- 明确说明如何禁用该功能
让我们验证一下相关文档是否完备:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1667 +/- ##
=========================================
Coverage ? 55.66%
=========================================
Files ? 173
Lines ? 17508
Branches ? 0
=========================================
Hits ? 9746
Misses ? 7762
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
看看 antd 官网下个版本的效果,目前搜索会触发 600+ 请求,cc @Jinbao1001 |
默认开启 magic comment 功能。
找了几个内部的大项目验证没问题,G6 官网开启这个 features 也发上线了,运行时正常。可以默认开启。
Summary by CodeRabbit
magicComment
属性,使其在构建过程中启用魔法注释功能。