Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: config codes organization #1618
refactor: config codes organization #1618
Changes from all commits
ff30ee5
21ae9e5
89d2abd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Check warning on line 3 in crates/mako/src/config/analyze.rs
crates/mako/src/config/analyze.rs#L3
Check warning on line 8 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L7-L8
Check warning on line 15 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L15
Check warning on line 18 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L18
Check warning on line 21 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L20-L21
Check warning on line 25 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L24-L25
Check warning on line 34 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L34
Check warning on line 38 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L37-L38
Check warning on line 41 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L41
Check warning on line 46 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L44-L46
Check warning on line 49 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L49
Check warning on line 54 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L52-L54
Check warning on line 61 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L58-L61
Check warning on line 63 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L63
Check warning on line 67 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L66-L67
Check warning on line 74 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L74
Check warning on line 93 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L77-L93
Check warning on line 107 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L97-L107
Check warning on line 109 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L109
Check warning on line 131 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L131
Check warning on line 135 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L135
Check warning on line 138 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L137-L138
Check warning on line 140 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L140
Check warning on line 142 in crates/mako/src/config/code_splitting.rs
crates/mako/src/config/code_splitting.rs#L142
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
避免在正则表达式解析失败时忽略错误
在反序列化正则表达式时,如果解析失败,当前实现会返回
Ok(None)
,这可能会导致潜在的错误被忽略。建议在解析失败时正确地传播错误,以便开发者及时发现并处理无效的正则表达式。可以修改代码以在解析失败时返回错误:
📝 Committable suggestion