fix: 🐛 concatenated module exported namespace should sort key

[stormslowly]

make dist js more stable.

Summary by CodeRabbit

• 新功能

  • 改进了模块的连接转换功能，允许更灵活地处理导入和导出，特别是在命名空间导入的上下文中。
  • 添加了新的测试功能，以验证导出声明变量作为命名空间时的行为。

• 修复

  • 优化了代码结构，简化了关键值属性的处理，提升了代码的清晰度和效率。

[coderabbitai]

Walkthrough

此次更改涉及 concatenated_transformer.rs 和 tests.rs 文件，主要是对 key_value_props 变量的类型进行了修改，从 PropOrSpread 向 KeyValueProp 转变，并简化了其填充方式。同时，新增了对 key_value_props 的排序操作。测试文件中引入了新的测试函数 test_export_decl_vars_import_as_namespace，并对 inner_trans_code 函数进行了重构和重命名，以支持不同的导入类型。

Changes

文件路径	更改摘要
crates/mako/src/plugins/tree_shaking/shake/module_concatenate/concatenated_transformer.rs	修改 key_value_props 的类型为 KeyValueProp，简化填充过程，并添加对该向量的排序操作。
crates/mako/src/plugins/tree_shaking/shake/module_concatenate/concatenated_transformer/tests.rs	新增测试函数 test_export_decl_vars_import_as_namespace，重构并重命名 inner_trans_code 为 inner_trans_code_imported_as，增加了 imported_type 参数以支持不同的导入类型，同时保持了向后兼容性。

Poem

在草地上跳跃的小兔，
新代码如春风轻拂。
属性更改，简化明了，
测试新增，功能更好。
兔子欢呼，乐在其中，
代码世界，真是无穷！ 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)

crates/mako/src/plugins/tree_shaking/shake/module_concatenate/concatenated_transformer/tests.rs (1)

Line range hint 717-775: 审查新函数 inner_trans_code_imported_as

此函数是新添加的，支持不同的导入类型。它使用 ConcatenatedTransform 类根据指定的导入类型执行转换。这是 PR 引入的新功能的关键部分，正确地处理了不同的导入情况。

建议在函数文档中添加更多注释，说明每个参数的作用和期望的行为，以提高代码的可读性和可维护性。

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5a0a0dc and 784329a.

Files selected for processing (2)

• crates/mako/src/plugins/tree_shaking/shake/module_concatenate/concatenated_transformer.rs (1 hunks)
• crates/mako/src/plugins/tree_shaking/shake/module_concatenate/concatenated_transformer/tests.rs (5 hunks)

Additional comments not posted (2)

crates/mako/src/plugins/tree_shaking/shake/module_concatenate/concatenated_transformer.rs (1)

354-368: 审查 key_value_props 的类型更改和排序操作

此次更改将 key_value_props 的类型从 Vec<PropOrSpread> 修改为 Vec<KeyValueProp>，并引入了按键排序的操作。这些更改有助于提高输出的稳定性和一致性，符合 PR 的目标。建议进行全面测试，以确保这些更改不会对系统的其他部分产生负面影响。

crates/mako/src/plugins/tree_shaking/shake/module_concatenate/concatenated_transformer/tests.rs (1)

642-688: 审查新的测试函数 test_export_decl_vars_import_as_namespace

此测试函数用于验证当变量作为命名空间导入时的导出行为。它正确地设置了命名空间导入类型，并检查输出是否符合预期的 JavaScript 代码和导出映射。这是验证新功能的重要测试，确保了代码的稳定性和预期行为。