Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: opt contributiong.md #1356

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Conversation

kiner-tang
Copy link
Contributor

@kiner-tang kiner-tang commented Jul 1, 2024

Summary by CodeRabbit

  • 文档
    • 简化了环境配置步骤,删除了冗余命令,并澄清了 mako 项目中的构建、测试、基准测试和性能分析命令。
    • 更新了发布流程说明,使其更加简洁一致。

Copy link
Contributor

coderabbitai bot commented Jul 1, 2024

Walkthrough

本次变更简化了 CONTRIBUTING.md 中的环境设置说明,移除了冗余的命令,并定义了更简洁的构建、测试、基准测试和性能分析命令。此外,还优化了发行流程说明,使其更加简洁和一致。

Changes

文件路径/模式 变更摘要
CONTRIBUTING.md 精简环境设置说明和命令格式,优化发行流程
... 更新了各命令的展示方式,统一去除冗余符号
移除了配置和命令中的不必要前缀符号,使命令更易读和简洁
... 将格式化和样式检查命令说明更新为简洁的指令
... 更新 codecov 和其他相关命令使用说明

Poem

🐇🔨📚
代码变简不繁杂,
指令简明易操作,
格式规范无冗余,
流程统一齐步走,
兔子云上笑呵呵。
🚀✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (1)
CONTRIBUTING.md (1)

Line range hint 185-185: 改进格式说明

将裸露的URL替换为链接格式,以提高可读性。

- Refer to https://yuque.antfin.com/mako/vz2gn4/vkp4qs8u4zcuxqoc for details.
+ Refer to [details](https://yuque.antfin.com/mako/vz2gn4/vkp4qs8u4zcuxqoc).
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 60466f1 and ee7840e.

Files selected for processing (1)
  • CONTRIBUTING.md (3 hunks)
Additional context used
LanguageTool
CONTRIBUTING.md

[misspelling] ~122-~122: Possible spelling mistake found.
Context: ...ruments/mac). - Install Xcode App from Mac AppStore and switch xcode dev tool with: ```bas...

(EN_MULTITOKEN_SPELLING_TWO)

Markdownlint
CONTRIBUTING.md

159-159: null
Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


185-185: null
Bare URL used

(MD034, no-bare-urls)

Additional comments not posted (21)
CONTRIBUTING.md (21)

7-7: 优化说明

建议将“First of all, you need to install the following tools:”改为“You need to install the following tools:”,去掉冗余的“First of all”。


16-17: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


23-24: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


30-31: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


37-37: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


43-50: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


58-60: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


66-71: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


77-78: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


81-82: 改进格式说明

将“Run fmt to format code.”改为“Use just fmt to format the code.”,将“Run lint to check code style.”改为“Use just lint to check the code style.”,使说明更清晰。


87-89: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


95-98: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


104-110: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


116-117: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


131-134: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


140-140: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


146-146: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


152-155: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


160-163: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


176-180: 去掉冗余的命令符号

在命令前去掉“-$”,保持一致性和简洁性。


125-125: 拼写错误

“xcode dev tool”应为“Xcode dev tool”。

- sudo xcode-select -s /Applications/Xcode.app/Contents/Developer
+ sudo xcode-select -s /Applications/Xcode.app/Contents/Developer

Likely invalid or redundant comment.

@sorrycc
Copy link
Member

sorrycc commented Jul 3, 2024

I think bash command keep $ prefix is better.

@kiner-tang
Copy link
Contributor Author

I think bash command keep $ prefix is better.

Okay, I'll add it back

@afc163
Copy link
Contributor

afc163 commented Jul 4, 2024

好像啥也没改?

@kiner-tang
Copy link
Contributor Author

好像啥也没改?

回退多了,我重新提交了

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (4)
CONTRIBUTING.md (4)

7-7: 建议恢复命令前的 $ 前缀

移除命令前的 $ 前缀可能会降低清晰度。恢复 $ 前缀可以更好地区分命令和输出。

- git clone git@github.com:umijs/mako.git
+ $ git clone git@github.com:umijs/mako.git

Line range hint 15-15:
建议恢复命令前的 $ 前缀

移除命令前的 $ 前缀可能会降低清晰度。恢复 $ 前缀可以更好地区分命令和输出。

- cargo build
+ $ cargo build

81-82: 建议恢复命令前的 $ 前缀

移除命令前的 $ 前缀可能会降低清晰度。恢复 $ 前缀可以更好地区分命令和输出。

- just fmt
+ $ just fmt

Line range hint 121-121:
建议恢复命令前的 $ 前缀

移除命令前的 $ 前缀可能会降低清晰度。恢复 $ 前缀可以更好地区分命令和输出。

- npm run release
+ $ npm run release
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ee7840e and 6a1c630.

Files selected for processing (1)
  • CONTRIBUTING.md (2 hunks)
Additional context used
Markdownlint
CONTRIBUTING.md

78-78: null
Dollar signs used before commands without showing output

(MD014, commands-show-output)

@afc163 afc163 merged commit 9af38c9 into umijs:master Jul 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants