Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code splitting granular #1318

Merged
merged 2 commits into from
Jun 28, 2024
Merged

fix: code splitting granular #1318

merged 2 commits into from
Jun 28, 2024

Conversation

xusd320
Copy link
Contributor

@xusd320 xusd320 commented Jun 27, 2024

codeSplitting bugfix:

  1. bundler-mako/index.js const { codeSplitting } 导致无法用 GRANULAR_CHUNKS 环境变量开启 granular 策略
  2. granular framework 规则中匹配 node_modules 的方式,如果用 tnpm 安装的依赖会用问题,导致匹配失效,tnpm 安装依赖的真实路径 node_modules/_react@17.0.2@react
  3. 加个保护,codeSplitting 阶段如果拆分出了重复 chunk 应该 panic,虽然目前没可能;
  4. 修复 e2e 及移除一些无用逻辑。

Summary by CodeRabbit

  • 功能更新
    • crates/mako/src/config/config.rs 文件中将 GenericUsizeDefault 结构体和其 value 方法的访问级别更改为公共。
    • crates/mako/src/generate/optimize_chunk.rs 文件中对代码拆分策略、块优化和处理重复块的逻辑进行调整。
    • e2e/fixtures/code-splitting.granular/expect.js 文件中重命名和重构了代码拆分设置中的块文件名。
    • packages/bundler-mako/index.js 文件中从 opts.config 的解构操作中移除了 codeSplitting 参数。

Copy link
Contributor

coderabbitai bot commented Jun 27, 2024

概述变化

Walkthrough

这次变更涉及对三个模块的调整。config.rs 中修改了 GenericUsizeDefault 结构体和其 value 方法的访问级别,使其变为公共可访问。在 optimize_chunk.rs 中,调整了代码拆分策略、块优化和处理重复块的逻辑。在 expect.js 文件中,对代码拆分设置进行了重命名和重构,以确保正确拆分库文件和共享块。

Changes

文件 修改摘要
crates/mako/src/config/config.rs 修改 GenericUsizeDefault 结构体及 value 方法的访问级别
crates/mako/src/generate/optimize_chunk.rs 调整代码拆分策略和处理重复块的逻辑
e2e/fixtures/code-splitting.granular/expect.js 重命名和重构代码拆分设置

公开的世界里,变化无穷无尽,

代码如诗般悠扬,改动如风吟。

公开的文件展新颜,

敲击键盘间,CodeRabbit畅游在变迁。


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xusd320 xusd320 merged commit d730458 into master Jun 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant