Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get_external_target_from_global_obj may be wrong #1293

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

xusd320
Copy link
Contributor

@xusd320 xusd320 commented Jun 19, 2024

之前 #1254 中,从 globalThis 上取 external 的方式改成了 globalThis['xxx'], 如果用户配的 external 是形如 'window._',会取不到。

解法:根据点号 '.' split external 配置, 只将左侧第一部分用中括号索引取值,其余保持原始取值方法,即 globalThis['window']._

Summary by CodeRabbit

  • 功能更新
    • 修改了resolve/mod.rsget_external_target_from_global_obj功能,使其能够处理包含点号的external字符串。
    • 添加了针对包含外部配置的场景的新测试用例。

@xusd320 xusd320 requested a review from PeachScript June 19, 2024 09:52
Copy link
Contributor

coderabbitai bot commented Jun 19, 2024

Walkthrough

整体变更概述:更新了crates/mako中的resolve/mod.rs文件,扩展了get_external_target_from_global_obj函数以处理包含特殊字符的情况,并添加了针对外部配置的新测试用例。

Changes

文件 变更摘要
crates/mako/src/resolve/mod.rs 扩展了get_external_target_from_global_obj函数以处理包含特殊字符的情况,添加了涉及外部配置的新测试用例。

Poem

兔子编码忙修改,
处理特殊字符游移。
新测试案例添香气,
疑难问题统统易。

希望这首小诗能为您的变更带来些许愉悦!


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xusd320 xusd320 force-pushed the fix/external-globalThis branch from cb678ee to ab94b17 Compare June 19, 2024 11:31
@xusd320 xusd320 force-pushed the fix/external-globalThis branch from ab94b17 to c92b472 Compare June 19, 2024 11:34
@stormslowly stormslowly merged commit 54874ab into master Jun 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants