-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/symbol conflict special case #1279
Conversation
变更总览
crates/mako/src/ast/tests.rs: 该功能变更修改了 crates/mako/src/build/transform.rs: 在
crates/mako/src/visitors/fix_symbol_conflict.rs: e2e/fixtures/javascript.issue-1274/expect.js: 新文件引入了解析构建结果、注入Jest测试实用工具和为测试目的需要特定文件的逻辑。 e2e/fixtures/javascript.issue-1274/mako.config.json: 新文件 e2e/fixtures/javascript.issue-1274/src/index.tsx: 新文件 packages/bundler-mako/package.json: 更新了 packages/mako/npm/darwin-arm64/package.json - packages/mako/npm/darwin-x64/package.json: 将版本从"0.6.0"更新到"0.6.1-canary.20240614.1"。 packages/mako/npm/linux-x64-gnu/package.json: 将版本从"0.6.0"更新到"0.6.1-canary.20240614.1"。 packages/mako/npm/linux-x64-musl/package.json: 更新版本号从"0.6.0"到"0.6.1-canary.20240614.1"。 packages/mako/package.json: 将
漫步指南对整体变更的高级总结,在80字内。 变更
诗歌
希望这个小诗能为你带来一丝喜悦! Note Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
close #1274
top level 的 symbol 重名为 _$m_Symbol
Summary by CodeRabbit
crates/mako/src/ast/tests.rs
:修改了gen_js_ast
函数,现在接受实现AsRef<str>
的泛型类型T
,在将输入分配给content
字段之前将其转换为字符串,确保与可转换为字符串的不同类型兼容。crates/mako/src/build/transform.rs
:在Transform
实现中的访问者列表中添加了FixSymbolConflict
访问者。crates/mako/src/visitors/fix_symbol_conflict.rs
:引入了FixSymbolConflict
结构体,处理模块中标识符的冲突。e2e/fixtures/javascript.issue-1274/expect.js
:添加了逻辑以解析构建结果、注入Jest测试工具并要求特定文件用于测试。e2e/fixtures/javascript.issue-1274/mako.config.json
:引入了配置设置,指定应用程序的目标浏览器为Internet Explorer 11。e2e/fixtures/javascript.issue-1274/src/index.tsx
:引入了forOf
函数和Symbol
类,包括相关测试用例。packages/bundler-mako/package.json
:更新了@umijs/mako
的版本。packages/mako/npm/darwin-arm64/package.json
、darwin-x64
、linux-x64-gnu
、linux-x64-musl
:更新了各个平台的@umijs/mako
版本和相应依赖。