Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize hmr with runtime error #1244

Merged
merged 1 commit into from
Jun 5, 2024
Merged

feat: optimize hmr with runtime error #1244

merged 1 commit into from
Jun 5, 2024

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Jun 5, 2024

ref: #1241

image

在没确定最优解之前,先做两件事缓解这个问题。

1、不捕获 unhandledrejection 错误
2、捕获到错误时提醒用户,Mako 会做刷新而非热更

Summary by CodeRabbit

  • 新功能
    • runtime_hmr_entry.js 中修改了 startReportingRuntimeErrors 函数,增加了对 unhandledrejection 事件的错误处理,并为运行时错误提供了更详细的控制台日志记录。
    • /src/index.tsx 中添加了一个带有错误消息的 promise 拒绝。
    • /src/App.tsx 中修改了 App 函数组件,使其返回 <div>App Modified</div> 而不是 <div>App</div>

Copy link
Contributor

coderabbitai bot commented Jun 5, 2024

Walkthrough

整体变化涉及修改运行时错误报告功能,增加对unhandledrejection事件的错误处理,并提供更详细的控制台日志记录运行时错误。另外,还包括测试热模块替换(HMR)中的运行时 Promise 拒绝错误,并验证渲染输出。

Changes

文件路径 变更摘要
crates/mako/src/runtime/runtime_hmr_entry.js 修改startReportingRuntimeErrors函数以处理unhandledrejection事件,并提供更详细的控制台日志记录运行时错误。
scripts/test-hmr.mjs 在 JavaScript 文件中测试热模块替换(HMR)时发生运行时 Promise 拒绝错误。测试场景包括在运行时修改/src/App.tsx中的App组件并验证渲染输出。

Poem

代码兔子欢天喜地跳,
运行时错误抓得牢牢。
HMR测试来无忧,
改动源码乐悠悠。
代码世界光辉耀。


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc merged commit f3cded3 into master Jun 5, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sorrycc-31aw branch June 5, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant