Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(concatenate): inner global var conflict with other modules top level vars #1100

Merged
merged 6 commits into from
Apr 29, 2024

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented Apr 25, 2024

problem

// inner1.js
let document = 1;
// inner2.js
document.createElement(...) //  here the document will be 1 

Copy link
Contributor

coderabbitai bot commented Apr 25, 2024

Walkthrough

The changes involve refactoring module concatenation logic, enhancing error handling, and introducing new test setups for Jest integration and module interactions.

Changes

File Summary
crates/mako/src/plugins/farm_tree_shake/shake/module_concatenate.rs Refactored optimize_module_graph for module concatenation and interop processing.
crates/mako/src/plugins/farm_tree_shake/shake/module_concatenate/concatenate_context.rs Added error handling, global variable management, and GlobalCollect struct.
crates/mako/src/plugins/farm_tree_shake/shake/module_concatenate/external_transformer.rs Added a new logic path in ExternalTransformer for visiting children.
e2e/fixtures/mako.scope-hoisting.inner_conflict_with_others_refed_global/* Introduces test setup and cases for specific script interactions.
e2e/fixtures/mako.scope-hoisting.ployfill_replace/* Adds test utilities and cases for scope hoisting polyfill replacement.
e2e/fixtures/mako.scope-hoisting.root_top_level_conflict_with_inner_refed_global/* Includes test scripts for root-level and inner-level import conflicts.

Poem

Code changes dance,
Jest and modules prance,
Refactored logic's trance,
Rabbit's code romance,
In files, a new expanse! 🐇📜


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc merged commit 1667f96 into master Apr 29, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/buffer_not_replace_in_inner branch April 29, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants