Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(concatenateModule): treat module as external when it contains unsupported syntax #1009

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented Apr 3, 2024

将包含特殊语法的模块节点,设置为非 root 非 inner 模块,这些语法需要留到后面的 transformer 统一处理。

特殊语法目前范围

  1. export * from “m” // 后继单独解决
  2. import("m")
  3. new Worker(.....)
  4. 直接或间接的 async 模块

Summary by CodeRabbit

  • Refactor
    • Updated logic for identifying unsupported syntax and optimized module ID handling.
    • Improved function naming within the test module.
  • New Features
    • Introduced variable exports and named modules in JavaScript files.
    • Added functionality for importing and creating worker instances.
  • Documentation
    • Enhanced test scripts and configuration settings for module optimization.

Copy link
Contributor

coderabbitai bot commented Apr 3, 2024

Walkthrough

The changes encompass improvements in module resolution logic, optimizations in managing module dependencies, and the addition of test scripts for scenarios involving CSS file imports and workers.

Changes

File Summary
crates/mako/src/module.rs Updated ResolveType struct to use is_dynamic_esm for a new condition check.
crates/mako/src/plugins/farm_tree_shake/shake/module_concatenate.rs
crates/mako/src/plugins/farm_tree_shake/shake/module_concatenate/external_transformer.rs
Refactored logic for identifying unsupported syntax and managing module IDs during optimization. Test function renamed.
e2e/fixtures/mako.scope-hoisting.import_external_css/a.js
e2e/fixtures/mako.scope-hoisting.import_external_css/b.js
e2e/fixtures/mako.scope-hoisting.import_external_css/c.js
e2e/fixtures/mako.scope-hoisting.import_external_css/cjs.js
...
Introduces exports, imports, and test scripts related to CSS modules and CommonJS.
e2e/fixtures/mako.scope-hoisting.import_worker/a.js
e2e/fixtures/mako.scope-hoisting.import_worker/b.js
e2e/fixtures/mako.scope-hoisting.import_worker/c.js
e2e/fixtures/mako.scope-hoisting.import_worker/cjs.js
...
Adds functionality for importing worker dependencies, CSS styling, and CommonJS modules.

Poem

A rabbit hops through code so fine,
Modules optimized, in a line.
CSS colors dance, workers play,
Changes made, a whimsical display.
🐇📦🎨

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc merged commit 7031d4a into master Apr 3, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/css_imported_in_concated_module branch April 3, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants