fix: bad output when chunk_loading_global containing quotation mark

umijs · Sep 11, 2024 · 23ed602 · 23ed602
1 parent 4897e32
commit 23ed602
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/crates/mako/src/generate/chunk_pot/str_impl.rs b/crates/mako/src/generate/chunk_pot/str_impl.rs
@@ -112,12 +112,16 @@ pub(super) fn render_normal_js_chunk(
 ) -> Result<ChunkFile> {
     let (content_buf, source_map_buf) = {
         let pot = chunk_pot;
+
+        // to avoid ' or " been included in chunk_loading_global
+        let safe_prop =
+            serde_json::from_str::<serde_json::Value>(&context.config.output.chunk_loading_global)
+                .unwrap();
+
         let chunk_prefix_code = format!(
-            r#"((typeof globalThis !== 'undefined' ? globalThis : self)['{}'] = (typeof globalThis !== 'undefined' ? globalThis : self)['{}'] || []).push([
-['{}'],"#,
-            context.config.output.chunk_loading_global,
-            context.config.output.chunk_loading_global,
-            pot.chunk_id,
+            r#"((typeof globalThis !== 'undefined' ? globalThis : self)[{}] = (typeof globalThis !== 'undefined' ? globalThis : self)[{}] || []).push([
+        ['{}'],"#,
+            safe_prop, safe_prop, pot.chunk_id,
         );
 
         let (chunk_content, chunk_raw_sourcemap) = pot_to_chunk_module_object_string(