-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity permission translation for US, UK and DK #18225
Entity permission translation for US, UK and DK #18225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Translation updates look good @ainokarita - but I just wanted to check about the line I've commented on.
...ent/src/packages/user/user-group/workspace/user-group/user-group-workspace-editor.element.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Just a couple of further minor things (and sorry, it seems a bit nit-picky for such a small update, but we just as well follow the existing conventions).
- Probably introducing a new key section for
userRights
is a bit much. I see in this component most keys are in theuser
section - e.g.user_languagesHelp
- so I'd suggest putting them under there,- So the keys you would reference would become e.g.
user_entityPermissionsLabel
,user_entityPermissionsDescription
- So the keys you would reference would become e.g.
- Suggest be consistent between
permission
andpermissions
- either is fine, but best to be be singular or plural and not both. - I noticed you changed the description to say "action type" over "entity type". What you have is probably better, but just wanted to check it was deliberate. Maybe even just "action" if fine, i.e. "Assign permissions for actions"?
Thanks Andy! Good points! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, works nicely. Thanks for updating this.
Prerequisites
Description
Translation was missing for User permissions in EN, EN-US and DK in the backoffice User groups settings section.
Added this in all 3 translation .ts files. You can see the changes in the backoffice: