Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity permission translation for US, UK and DK #18225

Merged

Conversation

ainokarita
Copy link
Contributor

@ainokarita ainokarita commented Feb 4, 2025

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Translation was missing for User permissions in EN, EN-US and DK in the backoffice User groups settings section.
Added this in all 3 translation .ts files. You can see the changes in the backoffice:

  • change your language to DK
  • Go to Users > User Groups and edit Administrators user group
  • Under Default permissions the Permissions header and description are now in Danish

image

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation updates look good @ainokarita - but I just wanted to check about the line I've commented on.

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a couple of further minor things (and sorry, it seems a bit nit-picky for such a small update, but we just as well follow the existing conventions).

  • Probably introducing a new key section for userRights is a bit much. I see in this component most keys are in the user section - e.g. user_languagesHelp - so I'd suggest putting them under there,
    • So the keys you would reference would become e.g. user_entityPermissionsLabel, user_entityPermissionsDescription
  • Suggest be consistent between permission and permissions - either is fine, but best to be be singular or plural and not both.
  • I noticed you changed the description to say "action type" over "entity type". What you have is probably better, but just wanted to check it was deliberate. Maybe even just "action" if fine, i.e. "Assign permissions for actions"?

@ainokarita
Copy link
Contributor Author

Thanks Andy! Good points!
I've made the suggested changes (language consistency, and key grouping). Changing the description to "Action type" was deliberate, felt that it was more descriptive in this case.

Copy link
Contributor

@AndyButland AndyButland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, works nicely. Thanks for updating this.

@AndyButland AndyButland enabled auto-merge (squash) February 5, 2025 10:31
@AndyButland AndyButland merged commit cce67b0 into umbraco:contrib Feb 5, 2025
29 checks passed
@ainokarita ainokarita deleted the entity-permission-translation branch February 7, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants