Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support KUBE_EDITOR environment variable with command line options #7

Closed
vsliouniaev opened this issue Jul 13, 2021 · 1 comment · Fixed by #14
Closed

Support KUBE_EDITOR environment variable with command line options #7

vsliouniaev opened this issue Jul 13, 2021 · 1 comment · Fixed by #14

Comments

@vsliouniaev
Copy link

Using the envronment variable

KUBE_EDITOR="code -w"

results in Error: exec: "code -w": executable file not found in $PATH
ulucinar added a commit that referenced this issue Jan 23, 2022
@ulucinar
Allow command-line options for the editor to be specified via KUBE_ED…
4763ef0 
…ITOR env. variable

- Fixes #7
- Example usage: KUBE_EDITOR="code -w" kubectl edit-status ...

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar ulucinar mentioned this issue Jan 23, 2022
Merged
ulucinar added a commit that referenced this issue Jan 23, 2022
@ulucinar
Allow command-line options for the editor to be specified via KUBE_ED…
dccb049 
…ITOR env. variable

- Fixes #7
- Example usage: KUBE_EDITOR="code -w" kubectl edit-status ...

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@ulucinar
Copy link
Owner

Hi @vsliouniaev,
Thank you! I did not know that we can use code in this way with edit-status. With #14, I have verified the following now works:

KUBE_EDITOR="code -w" kubectl edit-status pods/example-pod

, after the edited file is saved and the editor tab is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vsliouniaev @ulucinar