-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show 'Not set' in details page when company has no address #7603
Show 'Not set' in details page when company has no address #7603
Conversation
data-hub-frontend
|
Project |
data-hub-frontend
|
Branch Review |
bugfix/handle-empty-address-fields-on-details-tab
|
Run status |
|
Run duration | 08m 04s |
Commit |
|
Committer | Oliver Roberts |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
4
|
|
0
|
|
74
|
View all changes introduced in this branch ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7603 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 1126 1126
Lines 17486 17488 +2
Branches 5064 5066 +2
=======================================
+ Hits 15743 15746 +3
+ Misses 1743 1742 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, small Q about registered address, not sure if it needs a check as well?
Description of change
This PR fixes a bug in the details tab where if a company had no address, the application would raise an error due to the page being unable to read properties of the
company.address
object. Now, the code checks for an address first. If a company does not have one, it displays'Not set'
under the Addresses summary table.This fixes various recent sentry alerts:
Test instructions
The text
'Not set'
displaying under the Addresses summary table on the details (formerly business details) tab.Screenshots
Before
After
Checklist