-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cls2 1300 company files tab #7590
Conversation
data-hub-frontend
|
Project |
data-hub-frontend
|
Branch Review |
feature/CLS2-1300_Company-files-tab
|
Run status |
|
Run duration | 01m 39s |
Commit |
|
Committer | Stuart Mindt |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
15
|
View all changes introduced in this branch ↗︎ |
b3ec366
to
c6ed707
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7590 +/- ##
==========================================
- Coverage 90.03% 89.94% -0.09%
==========================================
Files 1126 1133 +7
Lines 17486 17543 +57
Branches 5064 5079 +15
==========================================
+ Hits 15743 15779 +36
- Misses 1743 1764 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments about the sorting functionality, but the rest looks good to me. Nice one @stuart-mindt!
src/client/components/CollectionList/CollectionSummaryCardItem.jsx
Outdated
Show resolved
Hide resolved
generated from commit f18d55b
Description of change
Adding files tab to company, listing files that have been added. New collection list item template added based on govuk summary card and summary list. This tab will be hidden initially when merged into main as the add and delete file functionality is still in development.
Test instructions
What should I see?
Screenshots
Before
N/A
After
Checklist