Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cls2 1300 company files tab #7590

Merged
merged 9 commits into from
Mar 10, 2025

Conversation

stuart-mindt
Copy link
Contributor

@stuart-mindt stuart-mindt commented Mar 5, 2025

Description of change

Adding files tab to company, listing files that have been added. New collection list item template added based on govuk summary card and summary list. This tab will be hidden initially when merged into main as the add and delete file functionality is still in development.

Test instructions

What should I see?

Screenshots

Before

N/A

After

image

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

Copy link

cypress bot commented Mar 5, 2025

data-hub-frontend    Run #59600

Run Properties:  status check passed Passed #59600  •  git commit 4ea4f85494: Removing unused code
Project data-hub-frontend
Branch Review feature/CLS2-1300_Company-files-tab
Run status status check passed Passed #59600
Run duration 01m 39s
Commit git commit 4ea4f85494: Removing unused code
Committer Stuart Mindt
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

@stuart-mindt stuart-mindt force-pushed the feature/CLS2-1300_Company-files-tab branch from b3ec366 to c6ed707 Compare March 5, 2025 12:23
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.94%. Comparing base (7071cc5) to head (4ea4f85).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...lient/modules/Files/CollectionList/transformers.js 84.21% 3 Missing ⚠️
...es/Files/CollectionList/CompanyFilesCollection.jsx 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7590      +/-   ##
==========================================
- Coverage   90.03%   89.94%   -0.09%     
==========================================
  Files        1126     1133       +7     
  Lines       17486    17543      +57     
  Branches     5064     5079      +15     
==========================================
+ Hits        15743    15779      +36     
- Misses       1743     1764      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stuart-mindt stuart-mindt marked this pull request as ready for review March 7, 2025 17:20
@stuart-mindt stuart-mindt requested a review from a team as a code owner March 7, 2025 17:20
Copy link
Contributor

@oliverjwroberts oliverjwroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments about the sorting functionality, but the rest looks good to me. Nice one @stuart-mindt!

@stuart-mindt stuart-mindt merged commit f18d55b into main Mar 10, 2025
16 checks passed
@stuart-mindt stuart-mindt deleted the feature/CLS2-1300_Company-files-tab branch March 10, 2025 15:51
chopkinsmade pushed a commit that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants