Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logging to the update_company_duns_number command #5971

Merged

Conversation

DeanElliott96
Copy link
Contributor

@DeanElliott96 DeanElliott96 commented Feb 21, 2025

Description of change

When doing a data cleanse from Dun & Bradstreet, we have attempted to update thousands of companies with a new duns number. Many of these failed however if was difficult to see all the reasons why for reporting.

This PR adds additional logging to capture the common errors and to also capture the errors as a whole and log at the end of the command rather than per record (problem when batching 1000+) companies at a time.

Checklist

  • Has this branch been rebased on top of the current main branch?
  • Is the CircleCI build passing?

@DeanElliott96 DeanElliott96 self-assigned this Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (945e140) to head (56d6eda).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5971   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files        1084     1084           
  Lines       25420    25459   +39     
  Branches     1678     1684    +6     
=======================================
+ Hits        24564    24602   +38     
  Misses        699      699           
- Partials      157      158    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DeanElliott96 DeanElliott96 marked this pull request as ready for review February 28, 2025 16:14
@DeanElliott96 DeanElliott96 requested a review from a team as a code owner February 28, 2025 16:14
@DeanElliott96 DeanElliott96 force-pushed the feature/TET-967-improve-duns-number-update-logging branch from 9af510e to 56d6eda Compare February 28, 2025 16:26
@DeanElliott96 DeanElliott96 merged commit 6fb97e3 into main Mar 3, 2025
7 checks passed
@DeanElliott96 DeanElliott96 deleted the feature/TET-967-improve-duns-number-update-logging branch March 3, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants