Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ingesting of EYB Leads without full name set #5880

Conversation

marijnkampf
Copy link
Contributor

@marijnkampf marijnkampf commented Dec 31, 2024

Allow ingesting of EYB Leads without full name set. Empty full name values default to 'Not set'

Description of change

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (0642315) to head (04ee5f0).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5880   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files        1059     1059           
  Lines       25201    25206    +5     
  Branches     1669     1670    +1     
=======================================
+ Hits        24356    24361    +5     
  Misses        689      689           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marijnkampf marijnkampf marked this pull request as ready for review December 31, 2024 09:44
@marijnkampf marijnkampf requested a review from a team as a code owner December 31, 2024 09:44
@marijnkampf marijnkampf merged commit b9f1e47 into main Jan 6, 2025
7 checks passed
@marijnkampf marijnkampf deleted the feature/CLS2-1159-Full-name-not-mandatory-on-EYB-contact-creation branch January 6, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants