Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/improve-contact-ingestion-select-performance #5864

Merged

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Dec 16, 2024

Description of change

Only select the minimum needed columns when processing contact consent, instead of the entire set of columns for a Contact

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@chopkinsmade chopkinsmade marked this pull request as ready for review December 16, 2024 14:40
@chopkinsmade chopkinsmade requested a review from a team as a code owner December 16, 2024 14:40
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (d0e826f) to head (c0f13c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5864   +/-   ##
=======================================
  Coverage   96.63%   96.64%           
=======================================
  Files        1058     1058           
  Lines       25160    25160           
  Branches     1669     1669           
=======================================
+ Hits        24314    24315    +1     
+ Misses        690      689    -1     
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade merged commit 7389f6a into main Dec 16, 2024
7 checks passed
@chopkinsmade chopkinsmade deleted the feature/improve-contact-ingestion-select-performance branch December 16, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants