Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EYB user ingestion task #5853

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

oliverjwroberts
Copy link
Contributor

@oliverjwroberts oliverjwroberts commented Dec 11, 2024

Description of change

This PR fixes an issue where incoming EYB user data had null values for companyWebsite, which weren't being mapped to empty strings. This caused the RQ job to error due to violating the database field not null constraint for EYBLead.company_website.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

This fixes an issue where incoming data had null values, which weren't being mapped. This caused the RQ job to error due to violating the database field not null constraint for `EYBLead.company_website`.
@oliverjwroberts oliverjwroberts self-assigned this Dec 11, 2024
@oliverjwroberts oliverjwroberts requested a review from a team as a code owner December 11, 2024 22:24
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (0100779) to head (91c0876).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5853   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files        1047     1047           
  Lines       24920    24920           
  Branches     1649     1649           
=======================================
  Hits        24075    24075           
  Misses        689      689           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliverjwroberts oliverjwroberts merged commit 3952635 into main Dec 12, 2024
7 checks passed
@oliverjwroberts oliverjwroberts deleted the fixup/CLS2-1114-fix-eyb-user-ingestion-task branch December 12, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants