Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cls2 1065 allow any string for eyb hiring choices #5849

Conversation

santoshdasa12345
Copy link
Contributor

@santoshdasa12345 santoshdasa12345 commented Dec 10, 2024

Description of change

This PR addresses for acccepting string in hiring choices for Eyb lead

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (2e7f888) to head (3dce265).
Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5849   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files        1042     1043    +1     
  Lines       24754    24759    +5     
  Branches     1645     1645           
=======================================
+ Hits        23889    23894    +5     
  Misses        709      709           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santoshdasa12345 santoshdasa12345 marked this pull request as ready for review December 10, 2024 14:16
@santoshdasa12345 santoshdasa12345 requested a review from a team as a code owner December 10, 2024 14:16
Copy link
Contributor

@oliverjwroberts oliverjwroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work Santosh!

@santoshdasa12345 santoshdasa12345 merged commit 0100779 into main Dec 11, 2024
7 checks passed
@santoshdasa12345 santoshdasa12345 deleted the feature/CLS2-1065-allow-any-string-for-eyb-hiring-choices branch December 11, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants