Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include eyb leads for investment projects in open search #5840

Conversation

marijnkampf
Copy link
Contributor

Description of change

Include EYB leads for investment projects in open search

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (aaeaea7) to head (89df725).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5840   +/-   ##
=======================================
  Coverage   96.60%   96.61%           
=======================================
  Files        1046     1046           
  Lines       24902    24904    +2     
  Branches     1647     1647           
=======================================
+ Hits        24057    24060    +3     
+ Misses        689      688    -1     
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marijnkampf marijnkampf marked this pull request as ready for review December 4, 2024 12:16
@marijnkampf marijnkampf requested a review from a team as a code owner December 4, 2024 12:16
Copy link
Contributor

@swenban swenban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment around testing but I have manually tested this with the frontend and it is behaving as expected so won't block you from merging

@marijnkampf marijnkampf force-pushed the feature/CLS2-1076-Include-EYB-lead-data-for-investment-project-in-open-search branch from 77066cd to 9b65f65 Compare December 9, 2024 10:39
For search added eyb_leads to prefetch_related in investment project
@marijnkampf marijnkampf merged commit 84afe4a into main Dec 9, 2024
7 checks passed
@marijnkampf marijnkampf deleted the feature/CLS2-1076-Include-EYB-lead-data-for-investment-project-in-open-search branch December 9, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants