-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include eyb leads for investment projects in open search #5840
Include eyb leads for investment projects in open search #5840
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5840 +/- ##
=======================================
Coverage 96.60% 96.61%
=======================================
Files 1046 1046
Lines 24902 24904 +2
Branches 1647 1647
=======================================
+ Hits 24057 24060 +3
+ Misses 689 688 -1
Partials 156 156 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a comment around testing but I have manually tested this with the frontend and it is behaving as expected so won't block you from merging
77066cd
to
9b65f65
Compare
For search added eyb_leads to prefetch_related in investment project
Description of change
Include EYB leads for investment projects in open search
Checklist
Has this branch been rebased on top of the current
main
branch?Explanation
The branch should not be stale or have conflicts at the time reviews are requested.
Is the CircleCI build passing?
General points
Other things to check
fixtures/test_data.yaml
is maintained when updating modelsSee docs/CONTRIBUTING.md for more guidelines.