-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature CLS2-982 add missing EYB lead search fields #5839
Feature CLS2-982 add missing EYB lead search fields #5839
Conversation
5b5f72a
to
38cb8a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, if coverage doesn't pick it up do you think this should have a test?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5839 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 1046 1046
Lines 24902 24902
Branches 1647 1647
=======================================
Hits 24057 24057
Misses 689 689
Partials 156 156 ☔ View full report in Codecov by Sentry. |
datahub/company_activity/tests/test_tasks/test_eyb_lead_tasks.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. A couple of queries, but nothing blocking the PR.
38bb34b
to
2ce49b5
Compare
Description of change
Add triage_created and is_high_value fields to open search for Investment Project EYB Leads.
Checklist
Has this branch been rebased on top of the current
main
branch?Explanation
The branch should not be stale or have conflicts at the time reviews are requested.
Is the CircleCI build passing?
General points
Other things to check
fixtures/test_data.yaml
is maintained when updating modelsSee docs/CONTRIBUTING.md for more guidelines.