Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature CLS2-982 add missing EYB lead search fields #5839

Merged

Conversation

marijnkampf
Copy link
Contributor

@marijnkampf marijnkampf commented Dec 3, 2024

Description of change

Add triage_created and is_high_value fields to open search for Investment Project EYB Leads.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@marijnkampf marijnkampf force-pushed the feature/CLS2-982-add-missing-eyb-lead-searc-fields branch from 5b5f72a to 38cb8a4 Compare December 3, 2024 16:29
@marijnkampf marijnkampf marked this pull request as ready for review December 3, 2024 16:29
@marijnkampf marijnkampf requested a review from a team as a code owner December 3, 2024 16:29
Copy link
Contributor

@DeanElliott96 DeanElliott96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if coverage doesn't pick it up do you think this should have a test?

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (aaeaea7) to head (d79459c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5839   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files        1046     1046           
  Lines       24902    24902           
  Branches     1647     1647           
=======================================
  Hits        24057    24057           
  Misses        689      689           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@oliverjwroberts oliverjwroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A couple of queries, but nothing blocking the PR.

@marijnkampf marijnkampf force-pushed the feature/CLS2-982-add-missing-eyb-lead-searc-fields branch from 38bb34b to 2ce49b5 Compare December 9, 2024 08:50
@marijnkampf marijnkampf merged commit 66858a2 into main Dec 9, 2024
7 checks passed
@marijnkampf marijnkampf deleted the feature/CLS2-982-add-missing-eyb-lead-searc-fields branch December 9, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants