Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLS2-1069 Fix marketing data ingestion bug #5830

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

samuele-mattiuzzo
Copy link
Contributor

@samuele-mattiuzzo samuele-mattiuzzo commented Nov 28, 2024

Description of change

We have found that no marketing data has been ingested since the release of the ingestion tasks in (v50.24.0)

The job fails when trying to access a non-existent key in the JSON.

This PR addresses that bug and makes sure the key isn't accessed directly via dict[] but relies on get() instead

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@samuele-mattiuzzo samuele-mattiuzzo marked this pull request as ready for review November 28, 2024 18:29
@samuele-mattiuzzo samuele-mattiuzzo requested a review from a team as a code owner November 28, 2024 18:29
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.50%. Comparing base (91c9bf7) to head (cce98ec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5830   +/-   ##
=======================================
  Coverage   96.50%   96.50%           
=======================================
  Files        1042     1042           
  Lines       24754    24754           
  Branches     1645     1645           
=======================================
+ Hits        23888    23889    +1     
+ Misses        710      709    -1     
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuele-mattiuzzo samuele-mattiuzzo merged commit 981623f into main Nov 29, 2024
7 checks passed
@samuele-mattiuzzo samuele-mattiuzzo deleted the bugfix/cls2-1069-marketing-data-ingestion-bug branch November 29, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants