Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email ingestion from Exchange. #5829

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Nov 28, 2024

Description of change

This changes where emails are ingested from, as we moved from S3 to Exchange.
It also switches the email processor from calendar to plain email.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner November 28, 2024 09:30
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (02bd991) to head (41ef911).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5829      +/-   ##
==========================================
+ Coverage   96.52%   96.60%   +0.08%     
==========================================
  Files        1046     1046              
  Lines       24889    24902      +13     
  Branches     1649     1647       -2     
==========================================
+ Hits        24024    24057      +33     
+ Misses        709      689      -20     
  Partials      156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@samuele-mattiuzzo samuele-mattiuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elcct left a couple of comments, but can still approve otherwise

@samuele-mattiuzzo
Copy link
Contributor

Also, looks like it needs more tests

@elcct elcct force-pushed the feature/fetch-emails-from-exchange branch from 551edf5 to 41ef911 Compare December 6, 2024 13:47
@elcct elcct merged commit aaeaea7 into main Dec 6, 2024
7 checks passed
@elcct elcct deleted the feature/fetch-emails-from-exchange branch December 6, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants