Bump mail-parser from 3.15.0 to 4.1.2 #5801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
aadam-ali
force-pushed
the
dependabot/pip/mail-parser-4.1.2
branch
from
68a35f9 to
e630027
Compare
dependabot
bot
force-pushed
the
dependabot/pip/mail-parser-4.1.2
branch
from
e630027 to
2f445ec
Compare
Bumps [mail-parser](https://github.com/SpamScope/mail-parser) from 3.15.0 to 4.1.2. - [Release notes](https://github.com/SpamScope/mail-parser/releases) - [Commits](SpamScope/mail-parser@v3.15.0...4.1.2) --- updated-dependencies: - dependency-name: mail-parser dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
oliverjwroberts
force-pushed
the
dependabot/pip/mail-parser-4.1.2
branch
from
2f445ec to
f1cab43
Compare
After bumping `mail-parser` to 4.1.2, `mailparser.parse_from_file().date` was returning a timezone aware date, whereas previously it was not. This was causing `django.utils.timezone.make_aware()` to raise an error.
oliverjwroberts
force-pushed
the
dependabot/pip/mail-parser-4.1.2
branch
2 times, most recently
from
00fd274 to
970602f
Compare
Upon removing the `simplejson` package and falling back to the built-in `json` library, it was found there were differences in the serialization of decimal numbers. This was causing the `test_gross_value_added_filters` test to fail when asserting the response of a project with max gross value added (99,999,989,999,999,999,990.000001). Rather than spending time re-configuring the JSON encoder that Django uses, it was decided to keep the `simplejson` package and explicitly list it in the `requirements.txt` file.
oliverjwroberts
force-pushed
the
dependabot/pip/mail-parser-4.1.2
branch
from
970602f to
a140ca6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5801 +/- ##
==========================================
- Coverage 96.50% 96.50% -0.01%
==========================================
Files 1042 1042
Lines 24754 24755 +1
Branches 1645 1645
==========================================
Hits 23889 23889
- Misses 709 710 +1
Partials 156 156 ☔ View full report in Codecov by Sentry. |
cgsunkel
approved these changes
Dec 4, 2024
DeanElliott96
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps mail-parser from 3.15.0 to 4.1.2.
Also, two changes were needed to make this upgrade work (notes from @oliverjwroberts):
mail-parserto 4.1.2,mailparser.parse_from_file().datewas returning a timezone aware date, whereas previously it was not. This was causingdjango.utils.timezone.make_aware()to raise an error. A ternary was added so that only naive datetime objects were passed to the make_aware() method.simplejsonpackage and falling back to the built-injsonlibrary, it was found there were differences in the serialization of decimal numbers. This was causing thetest_gross_value_added_filterstest to fail when asserting the response of a project with max gross value added (99,999,989,999,999,999,990.000001). Rather than re-configuring the JSON encoder that Django uses or refactoring the tests, which are both longer-term pieces of work, it was decided to keep thesimplejsonpackage and explicitly list it in therequirements.txtfile.Release notes
Sourced from mail-parser's releases.
Commits
a8ad997Merge branch 'release/4.1.2'64d84f9New versiona658f39Fixed GitHub pipeline9bed971Merge branch 'release/4.1.1' into develop5ed6c11Merge branch 'release/4.1.1'8040f00Update versione3e5a2bEnable pipeline with tagf214f17Merge branch 'release/4.1.0' into developfb34c0eMerge branch 'release/4.1.0'e83cc38New versionYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)