Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPS-628 Fix Django Admin link to investment project record on FE #5795

Merged
merged 0 commits into from
Nov 15, 2024

Conversation

swenban
Copy link
Contributor

@swenban swenban commented Nov 15, 2024

Description of change

The VIEW ON SITE button on the Change investment project page in Django Admin should take the user to the project page on the frontend of Data Hub. Instead of displaying the project, users are currently seeing a Page not found error message. This is because '/details' is missing from the end of the url link.
This PR corrects the issue.

To test

  • In Django Admin scroll down to INVESTMENT and select Investment Projects
  • Select a project
  • Click on the VIEW ON SITE button in the top right
Screenshot 2024-11-15 at 15 15 52
  • The relevant investment project page on Data Hub should be displayed without errors

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (7f3d486) to head (13b2ac3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5795   +/-   ##
=======================================
  Coverage   96.47%   96.48%           
=======================================
  Files        1037     1037           
  Lines       24625    24625           
  Branches     1637     1637           
=======================================
+ Hits        23758    23759    +1     
+ Misses        710      709    -1     
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swenban swenban marked this pull request as ready for review November 15, 2024 15:45
@swenban swenban requested a review from a team as a November 15, 2024 15:45
@swenban swenban merged this pull request into main Nov 15, 2024
7 checks passed
@swenban swenban deleted the fix/CPS-628-investment-project-view-on-site-link branch November 15, 2024 15:49
aadam-ali pushed a commit that referenced this pull request Nov 20, 2024
samuele-mattiuzzo pushed a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants