Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/improve-consent-job-logging #5782

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Nov 11, 2024

Description of change

  • Improve the logging inside the ingest contact consent task, by including the word consent in all logs to make searching cloudwatch easier.
  • Catch, and log any errors ingesting a file with a message to help debugging individual files

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (c591087) to head (db3e131).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5782   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files        1033     1033           
  Lines       24565    24571    +6     
  Branches     1633     1633           
=======================================
+ Hits        23698    23704    +6     
  Misses        710      710           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade force-pushed the feature/improve-consent-job-logging branch from 0284dc4 to db3e131 Compare November 11, 2024 15:55
@chopkinsmade chopkinsmade marked this pull request as ready for review November 11, 2024 16:13
@chopkinsmade chopkinsmade requested a review from a team as a code owner November 11, 2024 16:13
@chopkinsmade chopkinsmade merged commit 3c5c61e into main Nov 12, 2024
7 checks passed
@chopkinsmade chopkinsmade deleted the feature/improve-consent-job-logging branch November 12, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants