Add investment team members endpoints #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estment-team-members
…estment-team-members
Codecov Report
@@ Coverage Diff @@
## develop #295 +/- ##
===========================================
+ Coverage 92.87% 92.94% +0.07%
===========================================
Files 63 63
Lines 2427 2466 +39
Branches 215 218 +3
===========================================
+ Hits 2254 2292 +38
- Misses 145 146 +1
Partials 28 28
Continue to review full report at Codecov.
|
canni
reviewed
Jul 11, 2017
| @@ -4,7 +4,8 @@ | |||
|
|
|||
| from datahub.investment.views import ( | |||
| IProjectAuditViewSet, IProjectDocumentViewSet, IProjectRequirementsViewSet, | |||
| IProjectTeamViewSet, IProjectUnifiedViewSet, IProjectValueViewSet, IProjectViewSet | |||
| IProjectTeamMembersViewSet, IProjectTeamViewSet, IProjectUnifiedViewSet, IProjectValueViewSet, | |||
There was a problem hiding this comment.
This file is getting a bit convoluted, maybe a split?
There was a problem hiding this comment.
Will be removing the old project, value, requirements and team endpoints once a new front-end release is done, so it'll be a lot tidier after that.
canni
approved these changes
Jul 11, 2017
elcct
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes the reverse side of the archived_by relationship.