Improved search results. #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #291 +/- ##
==========================================
- Coverage 92.92% 92.9% -0.03%
==========================================
Files 63 63
Lines 2417 2423 +6
Branches 212 213 +1
==========================================
+ Hits 2246 2251 +5
+ Misses 145 144 -1
- Partials 26 28 +2
Continue to review full report at Codecov.
|
reupen
reviewed
Jul 10, 2017
datahub/search/models.py
Outdated
| @@ -307,7 +310,8 @@ class InvestmentProject(DocType, MapDBModelToDict): | |||
| 'id': String(index='not_analyzed'), | |||
| 'name': String() | |||
| }) # InvestmentType | |||
| name = String() | |||
| name = String(copy_to='name_keyword') | |||
| name_keyword = String(analyzer='lowercase_keyword_analyzer') | |||
| description = String() | |||
There was a problem hiding this comment.
Can we remove the duplicate description attribute?
reupen
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problem with non deterministic results whilst testing by setting number of shards to 1 for the test.
It uses alias field for names, which has lowercase keyword analyser mapped to it. This field is used in the term query to boost results of exact matches.