Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GET method for unarchiving #272

Merged
merged 4 commits into from
Jun 23, 2017
Merged

Conversation

reupen
Copy link
Contributor

@reupen reupen commented Jun 22, 2017

The front end is using POST now so GET can be removed.

@reupen reupen requested review from canni and elcct June 22, 2017 15:29
@reupen reupen changed the title Remove GET method for unarchiving Disable GET method for unarchiving Jun 22, 2017
@codecov-io
Copy link

codecov-io commented Jun 22, 2017

Codecov Report

Merging #272 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #272   +/-   ##
========================================
  Coverage    93.38%   93.38%           
========================================
  Files           58       58           
  Lines         2115     2115           
  Branches       194      194           
========================================
  Hits          1975     1975           
- Misses         117      118    +1     
+ Partials        23       22    -1
Impacted Files Coverage Δ
datahub/company/urls.py 100% <ø> (ø) ⬆️
datahub/core/mixins.py 100% <100%> (ø) ⬆️
datahub/company/admin.py 89.47% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e89452b...da5e822. Read the comment docs.

Copy link
Contributor

@canni canni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're disabling previously available calls I feel like there should be a test testing a 405 response for GET method

Copy link
Contributor

@canni canni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@reupen reupen merged commit 9bb5517 into develop Jun 23, 2017
@reupen reupen deleted the feature/remove-unarchive-get branch June 23, 2017 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants