Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add company v3 endpoints #252

Merged
merged 30 commits into from
Jun 13, 2017
Merged

Add company v3 endpoints #252

merged 30 commits into from
Jun 13, 2017

Conversation

reupen
Copy link
Contributor

@reupen reupen commented Jun 12, 2017

This adds the v3 company and Companies House endpoints.

reupen added 28 commits June 2, 2017 14:33
Embarassingly, no one knows what it was for.
Added to the explicitly defined CharFields to bring them in line with the implicitly defined ones.
@reupen reupen requested review from canni and elcct June 12, 2017 14:49
@codecov-io
Copy link

codecov-io commented Jun 12, 2017

Codecov Report

Merging #252 into develop will increase coverage by 0.19%.
The diff coverage is 98.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #252      +/-   ##
===========================================
+ Coverage    92.56%   92.76%   +0.19%     
===========================================
  Files           56       56              
  Lines         1924     1990      +66     
  Branches       179      179              
===========================================
+ Hits          1781     1846      +65     
- Misses         121      122       +1     
  Partials        22       22
Impacted Files Coverage Δ
datahub/core/mixins.py 100% <ø> (ø) ⬆️
datahub/company/views.py 100% <100%> (ø) ⬆️
datahub/core/serializers.py 91.83% <100%> (+0.34%) ⬆️
datahub/company/urls.py 100% <100%> (ø) ⬆️
datahub/company/serializers.py 97.81% <98.27%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 397056d...9d7b727. Read the comment docs.

@canni
Copy link
Contributor

canni commented Jun 12, 2017

Hmm why change of related name?

@reupen
Copy link
Contributor Author

reupen commented Jun 12, 2017

@canni
@jim68000 asked for the endpoint to use children instead of subsidiaries. So I changed the related name to keep it consistent.

@reupen reupen merged commit 74363a8 into develop Jun 13, 2017
@reupen reupen deleted the feature/DH-291-company-v3 branch June 13, 2017 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants