Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Interaction.contact from state #1556

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

reupen
Copy link
Contributor

@reupen reupen commented Mar 22, 2019

Description of change

This removes the deprecated contact field from the Interaction model state.

The column will be removed from the database in a following release.

This is currently blocked as the data science platform is still using the column corresponding to this field.

Checklist

  • Has a new newsfragment been created? Check changelog/README.rst for instructions
  • Have any relevant search models been updated?
  • Have any relevant fixtures (fixtures/test_data.yaml) been updated?
  • Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
  • Has the admin site been updated (for new models, fields etc.)?
  • Has the README been updated (if needed)?

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #1556 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1556      +/-   ##
===========================================
- Coverage    97.07%   97.05%   -0.03%     
===========================================
  Files          282      282              
  Lines         8414     8408       -6     
  Branches       813      812       -1     
===========================================
- Hits          8168     8160       -8     
- Misses         168      171       +3     
+ Partials        78       77       -1
Impacted Files Coverage Δ
datahub/interaction/admin.py 92.45% <ø> (-4.16%) ⬇️
.../cleanup/management/commands/delete_old_records.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72af90...da1cb12. Read the comment docs.

@reupen reupen added the blocked label Mar 28, 2019
@reupen reupen force-pushed the removal/interaction-contact-model-state branch from df9e8e4 to 63fa3c4 Compare April 15, 2019 12:50
@reupen reupen marked this pull request as ready for review April 15, 2019 13:03
@reupen reupen requested review from marcofucci, currycoder, elcct and marcuspp and removed request for marcofucci April 15, 2019 13:03
Copy link
Contributor

@currycoder currycoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question inline

@reupen reupen removed the blocked label Apr 18, 2019
@reupen reupen requested a review from currycoder April 18, 2019 09:44
This removes the deprecated `contact` field from the `Interaction` model state.

The column will be removed from the database in a following release.
@reupen reupen force-pushed the removal/interaction-contact-model-state branch from fd41187 to da1cb12 Compare April 18, 2019 15:18
@reupen reupen merged commit 0324864 into develop Apr 18, 2019
@reupen reupen deleted the removal/interaction-contact-model-state branch April 18, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants