Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove contact field from interactions in main API #1501

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

reupen
Copy link
Contributor

@reupen reupen commented Mar 5, 2019

Description of change

This removes the deprecated contact field from /v3/interaction and /v3/interaction/<id>.

Checklist

  • Has a new newsfragment been created? Check changelog/README.rst for instructions
  • Have any relevant search models been updated?
  • Have any relevant fixtures (fixtures/test_data.yaml) been updated?
  • Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
  • Has the admin site been updated (for new models, fields etc.)?
  • Has the README been updated (if needed)?

@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #1501 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1501   +/-   ##
========================================
  Coverage    96.91%   96.91%           
========================================
  Files          267      267           
  Lines         7855     7855           
  Branches       757      757           
========================================
  Hits          7613     7613           
  Misses         164      164           
  Partials        78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b13a7...97b6d67. Read the comment docs.

@reupen reupen force-pushed the feature/remove-interaction-contact-from-main-api branch from 62075bd to e9db1c6 Compare March 8, 2019 13:39
@reupen reupen marked this pull request as ready for review March 8, 2019 13:43
@reupen reupen requested review from marcofucci, elcct and marcuspp March 8, 2019 13:46
@reupen reupen force-pushed the feature/remove-interaction-contact-from-main-api branch from e9db1c6 to 97b6d67 Compare March 12, 2019 09:23
@reupen reupen merged commit 4391ded into develop Mar 12, 2019
@reupen reupen deleted the feature/remove-interaction-contact-from-main-api branch March 12, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants