Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add many-to-many contacts field to interactions #1404

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

reupen
Copy link
Contributor

@reupen reupen commented Jan 22, 2019

Description of change

This adds a many-to-many contacts field to the interaction model.

When the contact field is set via the API or via the admin site, the value is mirrored to the contacts field.

For now, contacts field is not exposed via the API or admin as the data in contact has not been fully replicated to contacts.

Checklist

  • Has a new newsfragment been created? Check changelog/README.rst for instructions
  • Have any relevant search models been updated?
  • Have any relevant fixtures (fixtures/test_data.yaml) been updated?
  • Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
  • Has the admin site been updated (for new models, fields etc.)?
  • Has the README been updated (if needed)?

@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #1404 into develop will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #1404      +/-   ##
==========================================
- Coverage    96.61%   96.6%   -0.02%     
==========================================
  Files          248     248              
  Lines         7096    7102       +6     
  Branches       661     662       +1     
==========================================
+ Hits          6856    6861       +5     
  Misses         164     164              
- Partials        76      77       +1
Impacted Files Coverage Δ
.../cleanup/management/commands/delete_old_records.py 100% <ø> (ø) ⬆️
datahub/interaction/admin.py 95.83% <83.33%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d08738...25e0034. Read the comment docs.

@reupen reupen force-pushed the feature/multiple-contacts-pt-1 branch from 56c06d4 to 6f9320e Compare January 22, 2019 16:53
This adds a many-to-many contacts field to the interaction model.

When the contact field is set via the API or via the admin site, the value is mirrored to the contacts field.

For now, this field is not exposed via the API or admin as the data in contact has not been fully replicated to contacts.
@reupen reupen force-pushed the feature/multiple-contacts-pt-1 branch from 2c0703b to 25e0034 Compare January 24, 2019 09:37
@reupen reupen merged commit 1abfb18 into develop Jan 24, 2019
@reupen reupen deleted the feature/multiple-contacts-pt-1 branch January 24, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants