Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CMakeLists.txt files to use imported targets #172
Update CMakeLists.txt files to use imported targets #172
Changes from all commits
bcd44ff
2f08ca3
5bb3d98
8a22c67
658a2c1
aae890c
c01d619
31c109a
3d20218
23a0f67
4e46c3c
b25cb37
9da6f05
78236ad
2f8c548
f1398b3
47fc948
2db4260
de8fb3d
8413bf0
28193c4
ecf73d4
88d5b3d
d10d25b
913bbc8
dbc6eaa
4e97d8f
d6f1903
cd5d7f9
d500e69
00765e7
f9d9bf1
bdab4e4
cbbff43
12d99e9
233531d
eb4b4ff
9755eda
f7e2d08
4a5a23b
44c4f87
11c1faa
f17627b
4b8c550
634bafa
9914083
e70d37f
41d8b5c
1d318f9
f10d144
7281ce7
d9dcd78
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be made into
libnems
consisting solely of the NEMS source code?ufs-weather-model-lib
is a collection oflibnems, fv3atm, ww3_nems
It will simplify the logic under hear as everything is
target_link_libraries
ortarget_compile_definitions
toufs-weather-model-lib
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you suggesting to rename
ufs-weather-model-lib
tonems
? I can do that. But I'm not sure I know how to makeufs-weather-model-lib
a collection ofnems
,fv3atm
, and optionallyww3_nems
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes.
you can create ufs-weather-model-lib from nems, fv3atm etc. same way you created fv3atm from fv3cpl, gfsphys, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But
fv3atm
, in addition to depending onfv3cpl
,gfsphysics
also contains code (atmos_model.F90
,fv3_cap.F90
, ...). How do I create library without code and then add other libraries as dependencies. I guess I do not understand what you mean by 'collection'? I do not know how to "create ufs-weather-model-lib from nems, fv3atm". I can only addnems
andfv3atm
as dependencies toufs-weather-model-lib
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? Wouldn't it inherit from
ufs-weather-model-lib
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is needed at this moment, because
ESMF_VERSION_MAJOR
is added asPRIVATE
definition toufs-weather-model-lib
. We can add it asPUBLIC
but then all users of ufs-weather-model-lib (ie. JEDI) will get it. Do we want that? I thought it makes more sense to keep it private. In any case this will all be replaced pretty soon.