Set default resolution with variables in tests #141

DeniseWorthen · 2020-07-15T17:50:51Z

Issue #135

Replaces hard-wired resolution dependent values in tests w/ variables.
Removes nems regression tests from rt.conf, removes rt_35d_nems.conf
Adds MOM_input_template for 1/2 deg resolution
Regression tests for CMEPS on Orion pass

Issue #134

Removes compset subdirectory and appBuilder files

Feature/add comparisons (#4)

merge develop/ufs-s2s-model

MOM_input template for initial condition files

merge fv3atm/develop

This reverts commit 0c8cb0b.

merge to latest develop

Debug mode capablility (#15)

Add debug compilation flag specification at top level (#17)

update to current ufs-weather-app (#19)

nomerg2atm, new MOM6 dev/emc

This reverts commit 57236a6.

Update FV3, NEMS (#21)

Update2020 01 (#23)

Update NEMS,FV3,CICE (#28)

Add CCPP to UFS-S2S-model

Add debug (ufs-community#70)

Remove IPD tests and CCPP repro tests from the regression test system…

Feature/alt compsetrun (ufs-community#75)

orion

remove coupled appBuilder files and compsets subdirectory

DeniseWorthen · 2020-07-15T19:42:27Z

Both Orion and Hera logs are posted, all tests pass.
Remove coupled appBuilder files and compset subdir.

junwang-noaa

Looks good, thanks. You may also to run it on dell?

MinsukJi-NOAA · 2020-07-15T19:54:42Z

tests/edit_inputs.sh

@@ -10,9 +10,14 @@ function edit_ice_in {
  jday=$(date -d "${SYEAR}-${SMONTH}-${SDAY} ${SHOUR}:00:00" +%j)
  istep0=$(( ((10#$jday-1)*86400 + 10#$SHOUR*3600) / DT_CICE ))

+  CICEGRID="grid_cice_NEMS_mx"$OCNRES".nc"


Why are CICEGRID and CICEMASK defined here? I see they are defined in default_vars.sh. Should any overriding be done in individual tests/tests/ files?

Yes, I think you are right.

The other line I was unsure about (even though it works) is setting ICERES in the fv3_conf/*.IN files. Unfortunately we have files with both "025" and "0.25" as resolution identifiers. Is there a better way (or place) to set that variable?

Here is what I think -- this will have to be tested. I leave it up to you to decide:

Delete CICEGRID and CICEMASK in default_vars

Move CICEGRID and CICEMASK defined in edit_inputs to fv3_conf/*.IN (grid_cice_NEMS_mx@[OCNRES].nc)

If ICRES always depends on OCNRES, maybe replace ICERES in default_vars with ICERES in fv3_conf/*.IN, and remove it from fv3_conf/*.IN

If you want to test these out, let me know. I can clone your branch and work on them.

That would be a huge help Minsuk, thanks.

ICERES and OCNRES will always represent the same resolution since they're always on the same grid. I can envision: mx025, 0.25
mx050, 0.50
mx100, 1.00

DeniseWorthen · 2020-07-15T20:16:01Z

tests/edit_inputs.sh

@@ -24,11 +29,24 @@ function edit_ice_in {
 }

 function edit_mom_input {
+
+  CHLCLIM="seawifs-clim-1997-2010."$NX_GLB"x"$NY_GLB".v20180328.nc"


I should probably move this and the FRUNOFF (below) to the individual tests also.

I think NX_GLB and NY_GLB need to be defined in individual tests if need to be overridden since their defaults are defined in default_vars. As to CHLCLIM, maybe define it in fv3_conf/*.in?

I just moved the variables CICEGRID, CICEMASK, CHLCLIM, FRUNOFF to default_vars.sh. I guess individual tests can override any one of these if needed in the future. I don't think it's a good idea to move them to fv3_conf/*.in. Running RT's on Hera with these changes now.

JessicaMeixner-NOAA

@DeniseWorthen this looks great! The clean up and the removal of NEMS tests is really exciting! I only had the one comment that some of the added things in the 025 MOM6_input might not be necessary, but can certainly be kept.

JessicaMeixner-NOAA · 2020-07-15T19:48:29Z

parm/MOM_input_template_025

@@ -82,11 +82,11 @@ WRITE_GEOM = 2                  ! default = 1
 TRIPOLAR_N = True               !   [Boolean] default = False
                                ! Use tripolar connectivity at the northern edge of the
                                ! domain.  With TRIPOLAR_N, NIGLOBAL must be even.
-NIGLOBAL = 1440                 !
+NIGLOBAL = NX_GLB               !


If we have another template for _050 do you even want to make these variables? I mean they are now, so we can keep them. But I don't know if it's strictly necessary?

Eventually I was hoping that all the MOM_input templates could be collapsed into one file, even for waves. It may not be possible but that was where I was going w/ this.

Agreed, I didn't see a way to do waves vs no waves without just adding an extra template but would be happy if there was a way to do this. I think there are even more differences between 1/2 and 1/4 than waves and no waves.

junwang-noaa · 2020-07-16T13:48:54Z

Denise, here I only see resolution and CHL_FILE changes, may I ask if there are other changes required for us to run 1/2 and 1/4 ocean?

…

On Thu, Jul 16, 2020 at 9:14 AM Jessica Meixner ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In parm/MOM_input_template_025 <#141 (comment)> : > @@ -82,11 +82,11 @@ WRITE_GEOM = 2 ! default = 1 TRIPOLAR_N = True ! [Boolean] default = False ! Use tripolar connectivity at the northern edge of the ! domain. With TRIPOLAR_N, NIGLOBAL must be even. -NIGLOBAL = 1440 ! +NIGLOBAL = NX_GLB ! Agreed, I didn't see a way to do waves vs no waves without just adding an extra template but would be happy if there was a way to do this. I think there are even more differences between 1/2 and 1/4 than waves and no waves. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#141 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI7D6TIZXVLJU2D4XORZFZLR334MFANCNFSM4O2YISDA> .

DeniseWorthen · 2020-07-16T14:12:56Z

There are a couple of other differences.
025 has a specified TOPO_EDITS_FILE, 050 does not have this file (so it would default to "")
025 has a different TIDEAMP file name.

There are also quite a few parameter differences (values) in the module_MOM_MEKE nml, MOM_lateral_mixing_coeffs nml, MOM_hor_visc nml and MOM_mixed_layer_restrat nml. Given the number of differences, really may not be possible to have a single template for different resolutions.

DeniseWorthen and others added 30 commits November 20, 2019 12:22

Merge pull request #1 from ufs-community/develop

ae4051d

Feature/add comparisons (#4)

Update .gitmodules

6c0ea1d

update submodules for nems,stochastic_physics

e72146c

update NEMS,stochastic_physics

190d88f

Merge pull request #2 from ufs-community/develop

b9c578e

merge develop/ufs-s2s-model

update CICE submode for feature/halfdeg (with build change) and

0c8cb0b

MOM_input template for initial condition files

Merge pull request #3 from ufs-community/develop

fd535ff

merge fv3atm/develop

Revert "update CICE submode for feature/halfdeg (with build change) and"

040d027

This reverts commit 0c8cb0b.

update CICE submodule

6d15ca7

update develop branch in my fork to use NOAA-EMC develop branches

7bf2632

Merge pull request #5 from ufs-community/develop

9d2b7a3

merge to latest develop

Merge pull request #6 from ufs-community/develop

d391b7c

Debug mode capablility (#15)

Update configure.fv3_coupled.hera.intel

bf4bbce

Update configure.fv3_coupled.cheyenne.intel

7809696

Merge pull request #7 from ufs-community/develop

6a9bf46

Add debug compilation flag specification at top level (#17)

Merge pull request #8 from ufs-community/develop

f94e746

update to current ufs-weather-app (#19)

update gitmodules, FV3 for gfsv16 incomming commit, NEMS for

57236a6

nomerg2atm, new MOM6 dev/emc

Revert changes that were meant for a branch, not develop

2ac97e1

This reverts commit 57236a6.

Merge pull request #9 from ufs-community/develop

06506f2

Update FV3, NEMS (#21)

Merge pull request #13 from ufs-community/develop

56e42ca

Update2020 01 (#23)

Merge pull request #15 from ufs-community/develop

fb154e5

Merge pull request #17 from ufs-community/develop

c5628b3

Update NEMS,FV3,CICE (#28)

Merge pull request #18 from ufs-community/develop

82910d9

Merge pull request #19 from ufs-community/develop

82b06f6

Add CCPP to UFS-S2S-model

Merge pull request #20 from ufs-community/develop

5058920

Merge pull request #22 from ufs-community/develop

1a8c02d

Add debug (ufs-community#70)

Merge pull request #23 from ufs-community/develop

9827916

Merge pull request #24 from ufs-community/develop

d13f9cf

Remove IPD tests and CCPP repro tests from the regression test system…

Merge pull request #25 from ufs-community/develop

5381fc4

Feature/alt compsetrun (ufs-community#75)

update MOM6 and CICE5 submodules for porting to

7d96f6f

orion

DeniseWorthen added 12 commits July 7, 2020 11:05

Merge remote-tracking branch 'upstream/develop' into develop

d0da9c8

Merge remote-tracking branch 'upstream/develop' into develop

c9fed74

initial commit of variable resolution rt tests

da35b7b

fix spacing

b0a78bd

fix scripting errors

72c1fc4

fix variable error

4c61fe8

Merge remote-tracking branch 'upstream/develop' into develop

f9a62f1

Merge branch 'develop' into feature/variable_res

542c458

Merge remote-tracking branch 'upstream/develop' into develop

c03fcde

Merge branch 'develop' into feature/variable_res

28a1ee7

cmeps regression tests for 1/4 deg resolution set w/ variable defs

f4f6de4

add Hera logs

cd7d6f4

remove coupled appBuilder files and compsets subdirectory

DeniseWorthen marked this pull request as ready for review July 15, 2020 19:42

DeniseWorthen requested review from MinsukJi-NOAA, binli2337, JessicaMeixner-NOAA and junwang-noaa July 15, 2020 19:42

junwang-noaa approved these changes Jul 15, 2020

View reviewed changes

MinsukJi-NOAA reviewed Jul 15, 2020

View reviewed changes

DeniseWorthen commented Jul 15, 2020

View reviewed changes

update NEMS submodule

04cb0aa

JessicaMeixner-NOAA approved these changes Jul 16, 2020

View reviewed changes

binli2337 approved these changes Jul 16, 2020

View reviewed changes

MinsukJi-NOAA approved these changes Jul 16, 2020

View reviewed changes

move vars from edit_inputs to default_vars (#44)

9a2996e

DeniseWorthen merged commit 9bbcd0b into ufs-community:develop Jul 16, 2020

DeniseWorthen deleted the feature/variable_res branch July 25, 2020 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set default resolution with variables in tests #141

Set default resolution with variables in tests #141

DeniseWorthen commented Jul 15, 2020 •

edited

Loading

DeniseWorthen commented Jul 15, 2020

junwang-noaa left a comment •

edited

Loading

MinsukJi-NOAA Jul 15, 2020

DeniseWorthen Jul 15, 2020

MinsukJi-NOAA Jul 15, 2020

MinsukJi-NOAA Jul 15, 2020

DeniseWorthen Jul 15, 2020

DeniseWorthen Jul 15, 2020

MinsukJi-NOAA Jul 15, 2020

MinsukJi-NOAA Jul 16, 2020

JessicaMeixner-NOAA left a comment

JessicaMeixner-NOAA Jul 15, 2020

DeniseWorthen Jul 16, 2020

JessicaMeixner-NOAA Jul 16, 2020

junwang-noaa commented Jul 16, 2020 via email

DeniseWorthen commented Jul 16, 2020

Set default resolution with variables in tests #141

Set default resolution with variables in tests #141

Conversation

DeniseWorthen commented Jul 15, 2020 • edited Loading

DeniseWorthen commented Jul 15, 2020

junwang-noaa left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junwang-noaa commented Jul 16, 2020 via email

DeniseWorthen commented Jul 16, 2020

DeniseWorthen commented Jul 15, 2020 •

edited

Loading

junwang-noaa left a comment •

edited

Loading