Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflow for UFS_UTILS #211

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Create workflow for UFS_UTILS #211

merged 2 commits into from
Nov 4, 2020

Conversation

kgerheiser
Copy link
Contributor

Automatically builds UFS_UTILS on every push and commit. No code changes.

@edwardhartnett
Copy link
Collaborator

Awesome!

@edwardhartnett
Copy link
Collaborator

This Fixes #182

@kgerheiser
Copy link
Contributor Author

kgerheiser commented Nov 4, 2020

Does what mean use the head of develop?

For UFS_UTILS, it will use whatever commit is currently being tested (PR, etc).

It uses the develop branch of NCEPLIBS for its prerequisites

@GeorgeGayno-NOAA
Copy link
Collaborator

Does what mean use the head of develop?

For UFS_UTILS, it will use whatever commit is currently being tested (PR, etc).

It uses the develop branch of NCEPLIBS for its prerequisites

I am asking about NCEPLIBS. Should we point to a specific commit of NCEPLIBS? If NCEPLIBS advances and UFS_UTILS is not ready for the latest update, will this test fail? And if the test fails, are PRs rejected?

@kgerheiser
Copy link
Contributor Author

I switched it to v1.2.0 (the latest release)

@edwardhartnett
Copy link
Collaborator

@GeorgeGayno-NOAA excellent questions! Kyle and I were recently discussing this very issue. As you point out this test uses the develop branch everywhere. We must also test against public releases.

In future tests and code need to be changed in harmony so that UFS_UTILS can work with any of the supported versions of NCEPLIBS, plus the develop branch. Changes to UFS_UTILS must not break compatibility with any of the supported versions.

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest change to use v1.2.0 of NCEPLIBS ran successfully under Kyle's branch. Will merge.

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 8a73766 into ufs-community:develop Nov 4, 2020
@kgerheiser kgerheiser deleted the feature/github-ci branch November 4, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants