Added all blog posts to blogs.js #500
Conversation
There was a problem hiding this comment.
went through some files! only changes requested were for spacing issues! when going through all files once more, ensure that spacing issues are addressed at every code block (I didn't read through all files). re-request review when done!
excellent job on the pr, though :DD
| time.style.color = color; | ||
| hex.style.color = color; | ||
| } | ||
| let date = new Date(); |
There was a problem hiding this comment.
nit: will this extra spacing show up on the blog? is it still readable? if so, then feel free to ignore this comment. Otherwise, you might need to revert these tabs back to spaces.
| sum(...args); // equivalent to sum(1, 2) | ||
| product(...args, 3); // equivalent to product(1, 2, 3) | ||
| product(0, ...args); // equivalent to product(0, 1, 2) | ||
| sum(...args); // equivalent to sum(1, 2) |
There was a problem hiding this comment.
revert back to original spacing for readability
| const { count } = this.state; | ||
| return ( | ||
| <div> | ||
| <h1>count: {count}</h1> |
There was a problem hiding this comment.
same nit here: if this extra spacing leads to less readability, revert back to original spacing. Otherwise, feel free to ignore!
| {/* We instead use an arrow function here */} | ||
| <button | ||
| onClick={() => { | ||
| this.incrementCounter(); |
There was a problem hiding this comment.
i fear this one might need to be reverted back to original formatting for readability
| return ( | ||
| <div> | ||
| <h3>{this.state.count}</h3> | ||
| <button onClick={this.onIncrement}>Increment</button> |
There was a problem hiding this comment.
same spacing nit as above
| return ( | ||
| <div> | ||
| <h2>Hour: {time.hour}</h2> | ||
| <h2>Minute: {time.minute}</h2> |
| setSuggestions(results); | ||
| }); | ||
| }, 500); // by 500ms | ||
| }, [search]); |
There was a problem hiding this comment.
revert back to original spacing here for readability
| if (search === '') { | ||
| setSuggestions([]); | ||
| return; | ||
| } |
There was a problem hiding this comment.
revert back to original spacing/formatting for this
| getSearchSuggestions(search).then(results => { | ||
| setSuggestions(results); | ||
| }); | ||
| }, 500); |
There was a problem hiding this comment.
revert to original spacing/formatting for this
| <div> | ||
| <input onChange={updateSearch} value={search} /> | ||
| <ul> | ||
| {suggestions.map(s => ( |
Overview
Changes
blogs.jsNotes