fix blog images and re-add all blogs #497
Conversation
| } | ||
|
|
||
| function product(a, b, c) { | ||
| return a * b * c; | ||
| return a * b * c; | ||
| } | ||
|
|
||
| const args = [1, 2]; |
There was a problem hiding this comment.
curious as to how this shows up on the blog. if the comments are no longer aligned (as it was before), can we change this back so the comments are aligned for readability?
| <button onClick={this.incrementCounter}> plus 1 </button> | ||
| </div> | ||
| ); | ||
| } |
There was a problem hiding this comment.
hmm if the spacing reflected here shows exactly on the blog page, maybe we want to reconsider using tabs and revert back to the previous spacing for readability. lowk this would apply to all code snippets in all blogs...
There was a problem hiding this comment.
ngl idk if i can manually do it for all the files..
| And yes, `bind`, `call`, `apply` do not work on arrow functions. | ||
| In fact, the arrow function can be equivalently written as | ||
|
|
||
| ```js | ||
| const a = () => {}; | ||
| // is equivalent to | ||
| const a = (function () {}).bind(this); | ||
| const a = function () {}.bind(this); |
There was a problem hiding this comment.
maybe add back parentheses for clarity?
| <li>{s}</li> | ||
| ))} | ||
| </ul> | ||
| ); |
There was a problem hiding this comment.
revert this change in formatting. less readable than the previous
| ))} | ||
| </ul> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
same idea here, I would revert formatting
| ))} | ||
| </ul> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
same idea on formatting
| ))} | ||
| </ul> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
same idea on formatting
| }; | ||
| const handleUserNameChange = e => { | ||
| setUsername(e.target.value); | ||
| }; |
There was a problem hiding this comment.
i think we should still use the parentheses here for clarity (applies to all examples in this blog)
|
@jamesmwu something's going on w the linter and it's changing the formatting for all the files (most notably fucking up the tabbing in the code snippets). i tried reverting the commit and re-committing without the linter but that didn't help at all. any ideas? |
Hmm I'm not particularly sure what's going on here, but you might need to manually adjust the linting rules in eslint. Or it could be if you have Prettier maybe you have a Prettier config that's overriding the styles we expect? If you aren't able to figure it out we can take a look at it during meeting this Sat 👍 |
i don't think it's prettier cuz the spaces in the files are normal. it's just that when it gets pushed onto github it becomes rlly weird. i tried it w/o the lint and it still pushed weird so i'm not rlly sure what's going on. |
✅ Deploy Preview for acm-hack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Changes
rehype-rawpackage to translate HTML in Markdown correctlyme when i change 32 files in one pr:
Type of change
Other notes
i hope i wrote and converted everything correctly... please help me double-check 🥺. i decided to leave the broken image in "Hackschool: Javascript and the DOM" since i couldn't decide what to do with it and removing it probably would've left readers more confused. estimated reading times were calculated with this website: https://niram.org/read/.
Related Issues
#468 #469
ong this is NOT a "good first issue" this got me lowk dead 😭