PXP-6245 PXP-9633 Poetry + Python 3.9 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulineribeyre
force-pushed
the
feat/3.9
branch
from
0f76865 to
3a9b2b8
Compare
jawadqur
reviewed
Feb 2, 2023
| @@ -1,31 +1,15 @@ | |||
| dist: trusty | |||
There was a problem hiding this comment.
Can we run these in GH actions? We can tackle that in a separate PR.
There was a problem hiding this comment.
yeah there are already more changes than i would have liked in this PR 😅
jawadqur
reviewed
Feb 2, 2023
| # To run: | ||
| # - Create and fill out `creds.json`: | ||
| # { | ||
| # "fence_host": "", |
There was a problem hiding this comment.
I don't remember if I hacked the config in helm, but can we also read these from environment variables?
There was a problem hiding this comment.
it doesn't look like you've updated sheepdog to read them from env vars, i don't see any code doing it
jawadqur
approved these changes
Feb 2, 2023
This was referenced Feb 2, 2023
Merged
This was referenced Apr 5, 2023
This was referenced Apr 13, 2023
This was referenced Apr 26, 2023
Updating Env chicagoland.pandemicresponsecommons.org - 2023.04 1682532240
uc-cdis/cdis-manifest#5995
Merged
This was referenced May 5, 2023
This was referenced Aug 15, 2023
This was referenced Dec 12, 2023
Merged
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-6245
Jira Ticket: PXP-9633
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
indexclientto 2.1.1Deployment changes