PXP-3408 Update Sheepdog to Python3 #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsJiaqi
commented
Oct 21, 2019
dev-requirements.txt
Outdated
| @@ -14,8 +14,7 @@ Sphinx==1.6.5 | |||
| sphinx_rtd_theme | |||
| flasgger==0.9.1 | |||
| -e git+https://git@github.com/uc-cdis/cdisutils-test.git@0.0.1#egg=cdisutilstest | |||
There was a problem hiding this comment.
@paulineribeyre do you know if cdisutils-test need to be updated?
There was a problem hiding this comment.
cdisutilstest has already been updated to python 3 (version 1.0.0 🎉)
There was a problem hiding this comment.
I'll bump it to 1.0.0 here then.
paulineribeyre
requested changes
Oct 21, 2019
| @@ -81,7 +82,7 @@ def app(tmpdir, request): | |||
| dictionary_setup(_app) | |||
| # this is to make sure sqlite is initialized | |||
| # for every unit test | |||
| reload(default_settings) | |||
| imp.reload(default_settings) | |||
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
itsJiaqi
force-pushed
the
chore/python3
branch
from
25e2476 to
11dc1f9
Compare
|
This pull request introduces 1 alert when merging aff7ae9 into af48394 - view on LGTM.com new alerts:
|
This was referenced Feb 14, 2020
This was referenced Mar 17, 2020
Merged
Merged
Merged
This was referenced Mar 31, 2020
This was referenced Apr 16, 2020
This was referenced Apr 27, 2020
This was referenced May 11, 2020
This was referenced Dec 18, 2023
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Breaking Changes
Dependency updates
release/py3branch to be compatible to python3Deployment changes