Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AUTH_SUBMISSION_LIST): import authutils validate_request #312

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

paulineribeyre
Copy link
Contributor

When AUTH_SUBMISSION_LIST config is True (which is the default value), sheepdog makes calls to function validate_request. This function used to be imported but this piece of code was removed by mistake in #298

Bug Fixes

  • Fix validate_request bug when AUTH_SUBMISSION_LIST config is not set or set to True

@PlanXCyborg
Copy link

Jenkins Build 1 : time taken 33 min
Check the https://jenkins.planx-pla.net/job/Performance%20tests%20for%20uc-cdis/job/sheepdog/job/PR-312/1/display/redirect

Test results:
Passed: 109, Failed: 0, Skipped: 0

Test Time (PR) Time (master) Diff
@ExportPerformanceTests @performance: Export all nodes of type: aliquot 0.244 0.171 0.07
@ExportPerformanceTests @performance: Export all nodes of type: case 0.259 0.343 -0.08
@ExportPerformanceTests @performance: Export all nodes of type: experiment 0.261 0.239 0.02
@ExportPerformanceTests @performance: Export all nodes of type: program 0.061 0.051 0.01
@ExportPerformanceTests @performance: Export all nodes of type: project 0.127 0.041 0.09
@ExportPerformanceTests @performance: Export all nodes of type: read_group 1.2 0.305 0.90
@ExportPerformanceTests @performance: Export all nodes of type: read_group_qc 0.163 0.072 0.09
@ExportPerformanceTests @performance: Export all nodes of type: sample 0.492 0.409 0.08
@ExportPerformanceTests @performance: Exporting a record by ID on nodes of type: aliquot 0.382 0.149 0.23
@ExportPerformanceTests @performance: Exporting a record by ID on nodes of type: case 0.35 0.218 0.13
@ExportPerformanceTests @performance: Exporting a record by ID on nodes of type: experiment 0.448 0.164 0.28
@ExportPerformanceTests @performance: Exporting a record by ID on nodes of type: read_group 0.183 0.053 0.13
@ExportPerformanceTests @performance: Exporting a record by ID on nodes of type: read_group_qc 0.229 0.06 0.17
@ExportPerformanceTests @performance: Exporting a record by ID on nodes of type: sample 0.228 0.079 0.15
@QueryPerformanceTests @performance: Executing bottomUp query # 0 0.805 1.105 -0.30
@QueryPerformanceTests @performance: Executing bottomUp query # 1 0.769 0.731 0.04
@QueryPerformanceTests @performance: Executing bottomUp query # 2 0.645 0.703 -0.06
@QueryPerformanceTests @performance: Executing bottomUp query # 3 0.794 0.574 0.22
@QueryPerformanceTests @performance: Executing bottomUp query # 5 0.369 0.446 -0.08
@QueryPerformanceTests @performance: Executing bottomUp query # 7 0.246 0.115 0.13
@QueryPerformanceTests @performance: Executing topDown query # 0 0.1 0.119 -0.02
@QueryPerformanceTests @performance: Executing topDown query # 1 0.139 0.126 0.01
@QueryPerformanceTests @performance: Executing topDown query # 2 0.195 0.151 0.04
@QueryPerformanceTests @performance: Executing topDown query # 3 0.296 0.385 -0.09
@QueryPerformanceTests @performance: Executing topDown query # 4 0.398 0.524 -0.13
@QueryPerformanceTests @performance: Executing topDown query # 5 0.444 0.701 -0.26
@QueryPerformanceTests @performance: Executing topDown query # 6 0.519 0.708 -0.19
@SubmissionPerformanceTests @performance: Submission acknowledgement 10 0.527 0.364 0.16
@SubmissionPerformanceTests @performance: Submission acknowledgement 100 2.438 3.224 -0.79
@SubmissionPerformanceTests @performance: Submission acknowledgement 1000 23.227 24.823 -1.60
@SubmissionPerformanceTests @performance: Submission aligned_reads_index 100 16.477 17.731 -1.25
@SubmissionPerformanceTests @performance: Submission aliquot 10 0.465 0.557 -0.09
@SubmissionPerformanceTests @performance: Submission aliquot 100 2.719 2.874 -0.15
@SubmissionPerformanceTests @performance: Submission aliquot 1000 25.037 30.816 -5.78
@SubmissionPerformanceTests @performance: Submission case 10 0.343 0.553 -0.21
@SubmissionPerformanceTests @performance: Submission case 100 2.842 3.352 -0.51
@SubmissionPerformanceTests @performance: Submission case 1000 26.248 30.746 -4.50
@SubmissionPerformanceTests @performance: Submission clinical_test 10 0.395 0.473 -0.08
@SubmissionPerformanceTests @performance: Submission clinical_test 100 2.8 3.699 -0.90
@SubmissionPerformanceTests @performance: Submission clinical_test 1000 26.581 28.74 -2.16
@SubmissionPerformanceTests @performance: Submission core_metadata_collection 10 0.651 0.594 0.06
@SubmissionPerformanceTests @performance: Submission core_metadata_collection 100 2.968 3.235 -0.27
@SubmissionPerformanceTests @performance: Submission core_metadata_collection 1000 25.713 29.439 -3.73
@SubmissionPerformanceTests @performance: Submission demographic 10 0.487 0.393 0.09
@SubmissionPerformanceTests @performance: Submission demographic 100 2.744 3.104 -0.36
@SubmissionPerformanceTests @performance: Submission demographic 1000 26.004 27.61 -1.61
@SubmissionPerformanceTests @performance: Submission diagnosis 10 0.559 0.433 0.13
@SubmissionPerformanceTests @performance: Submission diagnosis 100 3.065 4.087 -1.02
@SubmissionPerformanceTests @performance: Submission diagnosis 1000 35.298 32.236 3.06
@SubmissionPerformanceTests @performance: Submission experiment 10 0.494 0.607 -0.11
@SubmissionPerformanceTests @performance: Submission experiment 1000 24.37 28.052 -3.68
@SubmissionPerformanceTests @performance: Submission experimental_metadata 10 2.127 1.894 0.23
@SubmissionPerformanceTests @performance: Submission experimental_metadata 100 16.426 18.44 -2.01
@SubmissionPerformanceTests @performance: Submission exposure 10 0.476 0.37 0.11
@SubmissionPerformanceTests @performance: Submission exposure 100 2.527 2.855 -0.33
@SubmissionPerformanceTests @performance: Submission exposure 1000 26.505 25.094 1.41
@SubmissionPerformanceTests @performance: Submission family_history 10 0.83 0.379 0.45
@SubmissionPerformanceTests @performance: Submission keyword 10 0.499 0.347 0.15
@SubmissionPerformanceTests @performance: Submission keyword 100 2.679 2.997 -0.32
@SubmissionPerformanceTests @performance: Submission publication 100 2.587 3.004 -0.42
@SubmissionPerformanceTests @performance: Submission publication 1000 23.341 25.226 -1.89
@SubmissionPerformanceTests @performance: Submission read_group 10 0.37 0.499 -0.13
@SubmissionPerformanceTests @performance: Submission read_group 100 2.987 3.356 -0.37
@SubmissionPerformanceTests @performance: Submission read_group 1000 27.779 31.988 -4.21
@SubmissionPerformanceTests @performance: Submission read_group_qc 10 0.882 0.619 0.26
@SubmissionPerformanceTests @performance: Submission read_group_qc 100 4.172 4.57 -0.40
@SubmissionPerformanceTests @performance: Submission sample 10 0.362 0.458 -0.10
@SubmissionPerformanceTests @performance: Submission slide 10 0.444 0.376 0.07
@SubmissionPerformanceTests @performance: Submission slide 100 3.001 3.196 -0.20
@SubmissionPerformanceTests @performance: Submission slide 1000 26.406 30.339 -3.93
@SubmissionPerformanceTests @performance: Submission slide_count 100 2.594 2.907 -0.31
@SubmissionPerformanceTests @performance: Submission slide_image 10 1.778 2.159 -0.38
@SubmissionPerformanceTests @performance: Submission slide_image 100 16.042 17.633 -1.59
@SubmissionPerformanceTests @performance: Submission submitted_aligned_reads 10 2.48 1.738 0.74
@SubmissionPerformanceTests @performance: Submission submitted_copy_number 10 1.822 1.635 0.19
@SubmissionPerformanceTests @performance: Submission submitted_methylation 10 2.016 1.762 0.25
@SubmissionPerformanceTests @performance: Submission submitted_somatic_mutation 10 1.945 1.744 0.20
@SubmissionPerformanceTests @performance: Submission submitted_somatic_mutation 100 16.393 17.505 -1.11
@SubmissionPerformanceTests @performance: Submission submitted_unaligned_reads 10 2.021 1.77 0.25
@SubmissionPerformanceTests @performance: Submission treatment 10 0.429 0.354 0.07
@SubmissionPerformanceTests @performance: Submission treatment 100 2.547 2.884 -0.34
@SubmissionPerformanceTests @performance: Submission treatment 1000 24.545 26.142 -1.60

@paulineribeyre paulineribeyre merged commit 2ce2342 into master Oct 10, 2019
@paulineribeyre paulineribeyre deleted the fix/AUTH_SUBMISSION_LIST branch October 10, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants