This repository was archived by the owner on Feb 12, 2024. It is now read-only.
feat(alpine-docker): use alpine image #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frickjack
reviewed
Nov 19, 2018
|
|
||
| ENV DEBIAN_FRONTEND=noninteractive | ||
| FROM tiangolo/uwsgi-nginx:python3.6-alpine3.7 | ||
|
|
There was a problem hiding this comment.
Why don't we just copy this guy's Dockerfile to ~/cloud-automation/Docker/uwsgi-nginx, and make our own alpine base image that all of our python services inherit from?
Dockerfile
Outdated
|
|
||
| # ensure www-data user exists | ||
| RUN addgroup -g 82 -S www-data \ | ||
| && adduser -u 82 -D -S -G www-data www-data |
There was a problem hiding this comment.
I'm pretty sure alpine nginx already creates an nginx user - why don't we change nginx.conf to use that?
This was referenced Feb 10, 2020
Merged
This was referenced May 11, 2020
This was referenced Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an Alpine-based docker image instead of Ubuntu
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes
The Dockerfile now uses an Alpine image