updating job export to work with Helm #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please find the detailed integration test report here Please find the ci env pod logs here |
jawadqur
reviewed
Dec 5, 2024
job_export.py
Outdated
| DB_URL = f"jdbc:postgresql://{DB_HOST}/{DB_DATABASE}" | ||
| else: | ||
| DB_URL = None | ||
| print("DB_HOST or DB_DATABASE is missing. DB_URL cannot be constructed.") |
There was a problem hiding this comment.
Should we raise an error in this scenario? 🤔 So the application doesn't continue thinking everything is ok, but it has no database. Not sure what we usually do for that in other services.
There was a problem hiding this comment.
Yeah if no db exists then the job should throw runtime error
|
Please find the ci env pod logs here |
|
Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
jawadqur
approved these changes
Dec 5, 2024
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment changes
Our Helm charts utilize eternal secrets to create and manage our secrets. The new Peregrine-dbcreds secret is formatted differently and no longer uses json, so we need to edit the export job so the values can be read via environment variables.