Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix apply hide number resolver to as text agg results #274

Merged
merged 2 commits into from
Aug 28, 2024
Merged

fix apply hide number resolver to as text agg results #274

merged 2 commits into from
Aug 28, 2024

Conversation

mfshao
Copy link
Contributor

@mfshao mfshao commented Aug 27, 2024

Bug Fixes

  • Fixed a bug causing tiered access middleware didn't properly applied to aggregation results

Deployment changes

  • Important: all envs that has tiered access enabled should deploy a Guppy that has this fix

@github-actions GitHub Actions
Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_guppy\_service.py}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#23d18b}{\tt{8}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#23d18b}{\tt{8}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

MaribelleHGomez
MaribelleHGomez reviewed Aug 28, 2024
View reviewed changes
Copy link

@MaribelleHGomez MaribelleHGomez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the dockerfile there's a warning, should we be changing ln37 to
CMD ["bash", "./startServer.sh"]

@github-actions GitHub Actions
Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_guppy\_service.py}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#23d18b}{\tt{8}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#23d18b}{\tt{8}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

MaribelleHGomez
MaribelleHGomez approved these changes Aug 28, 2024
View reviewed changes
Copy link

@MaribelleHGomez MaribelleHGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@mfshao mfshao merged commit a43e002 into master Aug 28, 2024
8 checks passed
@mfshao mfshao deleted the fix/tiered-access-as-text-agg branch August 28, 2024 16:50
This was referenced Aug 28, 2024
Closed
Closed
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
Merged
@github-actions github-actions bot mentioned this pull request Oct 3, 2024
Open
grugna added a commit to chicagopcdc/guppy that referenced this pull request Oct 8, 2024
@grugna
do the same as (uc-cdis#274) but for granular
fe3741d
This was referenced Oct 9, 2024
Merged
Open
Merged
Merged
Merged
Open
Open
Merged
Merged
Merged
Open
Merged
Merged
This was referenced Oct 15, 2024
Merged
Open
matthewpeterkort pushed a commit to ACED-IDP/guppy that referenced this pull request Oct 24, 2024
@mfshao @matthewpeterkort
fix apply hide number resolver to as text agg results (uc-cdis#274)
91403ea 
* fix apply hide number resolver to as text agg results

* update dockerfile
mfshao added a commit that referenced this pull request Oct 29, 2024
@matthewpeterkort @dependabot
@mfshao @AlbertSnows @BinamB @snyk-bot @krishnaa05 @ocshawn @smvgarcia
Feature/refresh (#273)
c89aff7 
* Adds initial support for guppy refresh

* Fix Formatting

* Adds create method checking, updates tests

* fix: test

* Addresses PR feedback

* chore(deps): bump braces from 3.0.2 to 3.0.3 (#271)

* chore(deps): bump braces from 3.0.2 to 3.0.3

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* trigger gh action

* trigger travis

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mingfei Shao <mshao1@uchicago.edu>

* chore(deps-dev): bump ws from 6.2.2 to 6.2.3 (#272)

Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@6.2.2...6.2.3)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mingfei Shao <2475897+mfshao@users.noreply.github.com>

* address recent feedback

* fix apply hide number resolver to as text agg results (#274)

* fix apply hide number resolver to as text agg results

* update dockerfile

* Fix param ordering in server.js (#277)

Param order was wrong on changed line, put err first.
Refer to: https://expressjs.com/en/guide/error-handling.html

* fix: package.json & package-lock.json to reduce vulnerabilities (#280)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-SEND-7926862

Co-authored-by: snyk-bot <snyk-bot@snyk.io>

* Update integration_tests.yaml (#284)

* (PPS-1564 PPS-1567 PPS-1585): update body-parser and package lock file to use newer dependencies (#285)

* PPS-1564 PPS-1567 PPS-1585: update body-parser and package lock file to use newer dependencies
* PPS-1564 PPS-1567 PPS-1585: add file so nvm can set node version

* Update quickstart_helm.md (#289)

Fix a dead link

* Adds initial support for guppy refresh

* run linter

* bug fixes

* fix es-lint errors

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mingfei Shao <mshao1@uchicago.edu>
Co-authored-by: Mingfei Shao <2475897+mfshao@users.noreply.github.com>
Co-authored-by: Albert Snow <ajsnow2012@gmail.com>
Co-authored-by: Binam Bajracharya <44302895+BinamB@users.noreply.github.com>
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Co-authored-by: Krishna Agarwal <159047652+krishnaa05@users.noreply.github.com>
Co-authored-by: Shawn O'Connor <ocshawn@ocshawn.com>
Co-authored-by: smvgarcia <111767892+smvgarcia@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Oct 31, 2024
Closed
This was referenced Nov 14, 2024
Open
Merged
Open
Open
This was referenced Nov 22, 2024
Open
Merged
This was referenced Dec 11, 2024
Open
Open
This was referenced Jan 8, 2025
Open
Open
This was referenced Jan 21, 2025
Open
Merged
@github-actions github-actions bot mentioned this pull request Feb 7, 2025
Open
This was referenced Mar 4, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaribelleHGomez MaribelleHGomez MaribelleHGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfshao @MaribelleHGomez