(PXP-6617): remove scopes from jwt aud claim #3

vpsx · 2021-05-26T00:40:34Z

Jira Ticket: PXP-6617

Related Fence changes: uc-cdis/fence#839

Unsure why feat/initial has not been merged. Arborist currently requires feat/initial. Mariner currently requires the current tip of master.

Note: This PR also includes changes from the branch feat/initial, which improves handling around missing keys and fixes exp validation.

In step with Fence 5.0.0 changes to issued JWTs, in which scopes are moved out of the aud claim into a scopes claim, change JWT validation logic so that it does the same validation it was doing on the aud field, but does it on the scope field instead.
Do not require a scope claim to be present in the JWT if the calling function does not pass a required scope.

* Because this should not apply to scopes claim

… does not pass required scopes

Rudyard Richter and others added 7 commits August 24, 2018 14:08

feat(initial): fix token validation

06edbd2

feat(initial): improve error message

678f819

fix(aud-scopes): Change JWT aud field to scopes; same validation

c359049

fix(aud-scopes): rename test JWT aud field to scope

bb17d8a

fix(aud-scopes): Stop requiring at least one aud in selfValidate

55a9e1f

* Because this should not apply to scopes claim

fix(aud-scopes): Remove aud from required claims in validate_test

1a019d5

fix(aud-scopes): Don't require scope claim in JWT if calling function…

43330b1

… does not pass required scopes

vpsx mentioned this pull request May 26, 2021

(PXP-6617): remove scopes from jwt aud claim uc-cdis/arborist#130

Merged

Avantol13 approved these changes May 26, 2021

View reviewed changes

vpsx merged commit 909ef98 into master May 26, 2021

vpsx deleted the fix/aud-scopes branch June 8, 2021 15:24

vpsx restored the fix/aud-scopes branch June 8, 2021 15:28

vpsx deleted the fix/aud-scopes branch June 17, 2021 17:04

Provide feedback